Summary:	ASTERISK-09864: Inbound inband DTMF broken passing on out of band (process_ast_dsp)
Reporter:	Gregory Hinton Nietsky (irroot)	Labels:
Date Opened:	2007-07-12 08:59:47	Date Closed:	2007-12-27 15:33:31.000-0600
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_misdn
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-1.4.7.1.patch.isdn
Description:	the detected DTMF will never be passed back to asterisk out of band as required for IVR and the like looks like a trivial typo and a pain to pick up. patch fixes this and my IVR is working again.
Comments:	By: Gregory Hinton Nietsky (irroot) 2007-07-13 02:43:12 ok here is a sugestion ... the patch i uploaded makes all DTMF detected be passed out of band here some sugestions to have it configrable. 1)if the codec nativeformats allow pass the DTMF inband (ie a bridged TDM call) the current situation if not pass it out of band as per patch. 2)in addition to the above have a config option to always pass out of band (it makes no sense to always pass inband as the frame will be droped as a non compatible voice frame for non A/ULAW channels.asterisk should pass and generate the tones to pass inband if the channel requires so passing it always outofband imho is the safe default. By: Digium Subversion (svnbot) 2007-09-19 04:13:09 Repository: asterisk Revision: 83023 ------------------------------------------------------------------------ r83023 | crichter | 2007-09-19 04:13:07 -0500 (Wed, 19 Sep 2007) | 1 line added 'astdtmf' option to allow configuring the asterisk dtmf detector instead of the mISDN_dsp ones. also added the patch from irroot ASTERISK-9864, so that dtmf tones detected by the asterisk detector are passed outofband to asterisk, to make any use of dtmf tones at all. ------------------------------------------------------------------------ By: crich (crich) 2007-09-19 04:28:20 I've added your patch to svn 1.4 and trunk in r83023. Though you've got concerns which i share i think the best way would be that a AST_FRAME_DTMF frame contains a flag wether the DTMF tone is contained inband additional to the outofband info. Then the other channeldriver would need to check that flag and either generate the dtmf tone because it does not exist inband or just let the inband tone as it is and transfer it with the normal audiostream. By: Digium Subversion (svnbot) 2007-09-19 04:29:44 Repository: asterisk Revision: 83025 ------------------------------------------------------------------------ r83025 | crichter | 2007-09-19 04:29:43 -0500 (Wed, 19 Sep 2007) | 13 lines Merged revisions 83023-83024 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r83023 | crichter | 2007-09-19 11:31:55 +0200 (Mi, 19 Sep 2007) | 1 line added 'astdtmf' option to allow configuring the asterisk dtmf detector instead of the mISDN_dsp ones. also added the patch from irroot ASTERISK-9864, so that dtmf tones detected by the asterisk detector are passed outofband to asterisk, to make any use of dtmf tones at all. ........ r83024 | crichter | 2007-09-19 11:32:42 +0200 (Mi, 19 Sep 2007) | 1 line removed comment which violates the coding guidelines. ........ ------------------------------------------------------------------------ By: Gregory Hinton Nietsky (irroot) 2007-09-19 05:42:56 thank you yes that would make sense ... dealing with different technologies some of witch are incompatible is frustrating and often the solution is useing a big hammer to knock a square peg into a round hole