Summary:	ASTERISK-09862: RetryDial exits extension when attempting to "Retry" if announce file does not exist.
Reporter:	Jon Webster (jon)	Labels:
Date Opened:	2007-07-11 19:16:34	Date Closed:	2007-07-17 14:48:27
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_dial
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:
Description:	RetryDial in 1.2 would just not play an announcement and retry. Now, instead of retrying it ends extension execution (notice the hangup() is not processed). I'd like to restore the original behavior of not playing the non-existant file and redialing. However, if this is by design, then the command should not execute with a warning instead of working until its time to retry. ****** ADDITIONAL INFORMATION ****** pbx*CLI> dialplan add extension 31491,1,RetryDial(|1|3|SIP/office2|1|mg) into local replace pbx*CLI> dialplan add extension 31491,2,Hangup() into local replace Extension 31491@local (1) replace by '31491,1,RetryDial,|1|3|SIP/office2|1|mg'    -- Added extension '31491' priority 1 to local    -- Stopped music on hold on SIP/office2-0826b310  == Spawn extension (local, 31491, 1) exited non-zero on 'SIP/office2-0826b310'    -- Executing [31491@local:1] RetryDial("SIP/office2-0826b310", "|1|3|SIP/office2|1|mg") in new stack    -- Called office2    -- Started music on hold, class 'default', on channel 'SIP/office2-0826b310'    -- SIP/office2-08280040 is ringing    -- Nobody picked up in 1000 ms    -- Stopped music on hold on SIP/office2-0826b310 [Jul 11 20:14:07] WARNING[30968]: file.c:563 ast_openstream_full: File  does not exist in any format [Jul 11 20:14:07] WARNING[30968]: file.c:813 ast_streamfile: Unable to open  (format 0x4 (ulaw)): No such file or directory    -- Started music on hold, class 'default', on channel 'SIP/office2-0826b310'    -- Stopped music on hold on SIP/office2-0826b310  == Spawn extension (local, 31491, 1) exited non-zero on 'SIP/office2-0826b310' pbx*CLI>
Comments:	By: Digium Subversion (svnbot) 2007-07-16 12:59:21 Repository: asterisk Revision: 75253 ------------------------------------------------------------------------ r75253 | mmichelson | 2007-07-16 12:59:20 -0500 (Mon, 16 Jul 2007) | 8 lines Restoring functionality from 1.2 wherein Retrydial will not exit if there is no announce file specified. This change makes it so that if there is no announce file specified, the application will continue until finished (or caller hangs up). If a bogus announce file is specified, then a warning message will be printed saying that the file could not be found, but execution will still continue. (closes issue ASTERISK-9862, reported by jon, patched by me) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-16 13:01:24 Repository: asterisk Revision: 75254 ------------------------------------------------------------------------ r75254 | mmichelson | 2007-07-16 13:01:23 -0500 (Mon, 16 Jul 2007) | 16 lines Merged revisions 75253 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r75253 | mmichelson | 2007-07-16 13:16:15 -0500 (Mon, 16 Jul 2007) | 8 lines Restoring functionality from 1.2 wherein Retrydial will not exit if there is no announce file specified. This change makes it so that if there is no announce file specified, the application will continue until finished (or caller hangs up). If a bogus announce file is specified, then a warning message will be printed saying that the file could not be found, but execution will still continue. (closes issue ASTERISK-9862, reported by jon, patched by me) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-17 14:46:53 Repository: asterisk Revision: 75405 ------------------------------------------------------------------------ r75405 | mmichelson | 2007-07-17 14:46:52 -0500 (Tue, 17 Jul 2007) | 6 lines Fixing an error I made earlier. ast_fileexists can return -1 on failure, so I need to be sure that we only enter the if statement if it is successful. Related to my fix to issue ASTERISK-9862 ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-17 14:48:27 Repository: asterisk Revision: 75406 ------------------------------------------------------------------------ r75406 | mmichelson | 2007-07-17 14:48:25 -0500 (Tue, 17 Jul 2007) | 14 lines Merged revisions 75405 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r75405 | mmichelson | 2007-07-17 15:03:48 -0500 (Tue, 17 Jul 2007) | 6 lines Fixing an error I made earlier. ast_fileexists can return -1 on failure, so I need to be sure that we only enter the if statement if it is successful. Related to my fix to issue ASTERISK-9862 ........ ------------------------------------------------------------------------