Summary:	ASTERISK-09856: Agent logged on via AgentLogin isn't logged off by "agent logoff" CLI command with soft option
Reporter:	Makoto Dei (makoto)	Labels:
Date Opened:	2007-07-11 02:26:24	Date Closed:	2007-07-12 17:43:42
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_agent
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-1.2.18-agentlogin-softlogoff.patch
Description:	Agent logged on via AgentLogin isn't logged off by "agent logoff" CLI command with soft option. Without soft option, works fine. Attached patch will fix the issue. ****** STEPS TO REPRODUCE ****** 1. Log on via AgentLogin 2. From CLI, agent logoff Agent/xxxx soft The agent is not logged off.
Comments:	By: Mark Michelson (mmichelson) 2007-07-11 15:55:06 Thanks for the patch! This works well. I had to make a slight modification for it to work in 1.4 and trunk, but it's essentially the same. By: Digium Subversion (svnbot) 2007-07-11 15:55:44 Repository: asterisk Revision: 74719 ------------------------------------------------------------------------ r74719 | mmichelson | 2007-07-11 15:55:44 -0500 (Wed, 11 Jul 2007) | 5 lines The cli command "agent logoff Agent/x soft" did not work...at all. Now it does. (closes issue ASTERISK-9856, reported and patched by makoto, with slight modification for 1.4 and trunk by me) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-11 15:57:24 Repository: asterisk Revision: 74722 ------------------------------------------------------------------------ r74722 | mmichelson | 2007-07-11 15:57:22 -0500 (Wed, 11 Jul 2007) | 13 lines Merged revisions 74719 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r74719 | mmichelson | 2007-07-11 16:12:30 -0500 (Wed, 11 Jul 2007) | 5 lines The cli command "agent logoff Agent/x soft" did not work...at all. Now it does. (closes issue ASTERISK-9856, reported and patched by makoto, with slight modification for 1.4 and trunk by me) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-11 15:59:02 Repository: asterisk Revision: 74726 ------------------------------------------------------------------------ r74726 | mmichelson | 2007-07-11 15:59:01 -0500 (Wed, 11 Jul 2007) | 21 lines Merged revisions 74722 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r74722 | mmichelson | 2007-07-11 16:14:09 -0500 (Wed, 11 Jul 2007) | 13 lines Merged revisions 74719 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r74719 | mmichelson | 2007-07-11 16:12:30 -0500 (Wed, 11 Jul 2007) | 5 lines The cli command "agent logoff Agent/x soft" did not work...at all. Now it does. (closes issue ASTERISK-9856, reported and patched by makoto, with slight modification for 1.4 and trunk by me) ........ ................ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-11 16:11:37 Repository: asterisk Revision: 74743 ------------------------------------------------------------------------ r74743 | tilghman | 2007-07-11 16:11:37 -0500 (Wed, 11 Jul 2007) | 49 lines Merged revisions 74703-74705,74713,74726 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r74703 | file | 2007-07-11 15:07:07 -0500 (Wed, 11 Jul 2007) | 2 lines Use linkedlist macros for UDPTL protocol list. ................ r74704 | file | 2007-07-11 15:40:33 -0500 (Wed, 11 Jul 2007) | 2 lines Clean up pbx_spool. So many nested if statements... ................ r74705 | file | 2007-07-11 15:57:25 -0500 (Wed, 11 Jul 2007) | 2 lines Code cleanup of res_smdi ................ r74713 | file | 2007-07-11 16:09:42 -0500 (Wed, 11 Jul 2007) | 2 lines Code cleanup of res_agi ................ r74726 | mmichelson | 2007-07-11 16:15:47 -0500 (Wed, 11 Jul 2007) | 21 lines Merged revisions 74722 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r74722 | mmichelson | 2007-07-11 16:14:09 -0500 (Wed, 11 Jul 2007) | 13 lines Merged revisions 74719 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r74719 | mmichelson | 2007-07-11 16:12:30 -0500 (Wed, 11 Jul 2007) | 5 lines The cli command "agent logoff Agent/x soft" did not work...at all. Now it does. (closes issue ASTERISK-9856, reported and patched by makoto, with slight modification for 1.4 and trunk by me) ........ ................ ................ ------------------------------------------------------------------------ By: Makoto Dei (makoto) 2007-07-11 21:22:07 For 1.4 and trunk, I think that using p->deferlogoff is better than p->loginstart and the change in agent_logoff() should be reverted because p->loginstart is used after logoff. By: Digium Subversion (svnbot) 2007-07-12 17:43:42 Repository: asterisk Revision: 74998 ------------------------------------------------------------------------ r74998 | mmichelson | 2007-07-12 17:43:41 -0500 (Thu, 12 Jul 2007) | 6 lines Change to my previous fix regarding agent logoff soft. Now uses deferlogoff instead of loginstart since loginstart is used after logoff. Thanks to makoto for pointing this out and suggesting the fix. (closes issue ASTERISK-9856, reported and patched by makoto, with modification by me) ------------------------------------------------------------------------