Summary:ASTERISK-09834: Add the ability to not play musiconhold but plain old ringing instead
Reporter:Gregory Hinton Nietsky (irroot)Labels:
Date Opened:2007-07-08 10:16:38Date Closed:2007-07-20 19:58:19
Versions:Frequency of
Environment:Attachments:( 0) app_queue.ringing.patch2
this will allow you to play normal ringing instead of musiconhold to a waiting caller.

playmusiconhold = no in queues.conf/equiv the default is yes

Comments:By: Russell Bryant (russell) 2007-07-08 22:44:05

What is different between this and the 'r' option that already exists to Queue() ?

(Note that I can't see your code yet, because the license has not yet been approved).

By: Gregory Hinton Nietsky (irroot) 2007-07-09 02:26:50

ok you got me its a older patch that overlaps with the r option there still some places where musiconhold is started however. ie the periodic announce ...

i have a user that wants no music on hold at all and it did creep in that was the3 start of this patch im cleaning it up at the moment ...

By: Gregory Hinton Nietsky (irroot) 2007-07-09 03:50:08

with the ringing option possition announcement and periodic announcement are turned off this was a requirement but with no music on hold the patch will allow this .... therefore i dont use the r option.

what im busy doing is allowing the annoucements based on the r option as opposed to a queue option.

By: Russell Bryant (russell) 2007-07-09 09:57:11

Your license agreement was not approved, so we can not look at your submission.  Please reply to the email you received regarding your license agreement and feel free to re-open this issue once it is resolved.

By: Gregory Hinton Nietsky (irroot) 2007-07-10 10:02:33

licence issue is resolved

By: Gregory Hinton Nietsky (irroot) 2007-07-19 05:23:38

ok just to clear up any confusion i introduced.

the current patch extends the 'r' option to allow announcements (currently disabled with the 'r' option) starting and stoping ringing where required.

this is a tidy version of a rather convoluted patch that has been with me for a while where i had a queue option "playmusiconhold" implemented. this option has been replaced with the 'r' option completely.

By: Dmitry Andrianov (dimas) 2007-07-19 07:35:52

aside from the feature itself - just curious why don't tou create background_start(qe)/background_stop(qe) istead of having "if (ringing)" across all the code?

By: Gregory Hinton Nietsky (irroot) 2007-07-19 08:48:08

that is a very good idea ...

the existing code has implimented it as such i just extended it to allow for announcements.

By: Steve Murphy (murf) 2007-07-20 19:54:18

merged this into trunk via 76220; thought about it afterwards, and updated
the "show application queue" doc string to say that the 'r' option allows periodic announcements, if applicable. Merged that in 76222.

I had to make a few small interpolations to make it fit in trunk; if you could review these, I would much appreciate it.

I didn't apply it to 1.4, as this really can be considered an enhancement.

Many thanks, we appreciate the time and effort you put into this. If there are any problems, or you have further updates, please feel free to re-open this issue and we'll get on it pronto.

By: Steve Murphy (murf) 2007-07-20 19:58:18

Ugh-- forgot to assign it to myself; that reopened it. So I'm closing it again.
Sorry for the bother!