[Home]

Summary:ASTERISK-09833: [patch] Fix for response to CoreSettingsAction
Reporter:Stefan Reuter (srt)Labels:
Date Opened:2007-07-07 19:41:02Date Closed:2007-07-08 20:09:00
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/ManagerInterface
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The parameters passed to astman_append are in the wrong order.

****** ADDITIONAL INFORMATION ******

Index: main/manager.c
===================================================================
--- main/manager.c      (revision 73841)
+++ main/manager.c      (working copy)
@@ -2260,8 +2260,8 @@
                       "CoreCDRenabled: %s\r\n"
                       "CoreHTTPenabled: %s\r\n"
                       ,
+                       idText,
                       AMI_VERSION,
-                       idText,
                       ASTERISK_VERSION,
                       ast_config_AST_SYSTEM_NAME,
                       option_maxcalls,
Comments:By: Stefan Reuter (srt) 2007-07-07 19:46:00

It would be even better to use astman_start_ack(s, m);

Additionally there are problems when passing no ActionId (for CoreSettings and CoreStatus) as they do not properly initialize the idText. Example:

Action: CoreStatus

Response: Success
��sCoreStartupTime: 01:45:20
CoreReloadTime: 01:00:00
CoreCurrentCalls: 0
By: Digium Subversion (svnbot) 2007-07-08 20:08:17

Repository: asterisk
Revision: 73932

------------------------------------------------------------------------
r73932 | file | 2007-07-08 20:08:16 -0500 (Sun, 08 Jul 2007) | 2 lines

Make sure the idText variable is empty, and put it in the right place for the manager ack packet. (issue ASTERISK-9833 reported by srt)

------------------------------------------------------------------------
By: Joshua C. Colp (jcolp) 2007-07-08 20:08:59

Fixed in trunk as of revision 73932.