Summary:	ASTERISK-09824: Incorrect destination mailbox when forwarding message with IMAP storage
Reporter:	James Rothenberger (jaroth)	Labels:
Date Opened:	2007-07-06 13:57:27	Date Closed:	2007-07-10 18:17:19
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_voicemail
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) forward_imap_v2.patch ( 1) forward_imap_v3.patch ( 2) forward_imap.patch
Description:	When forwarding a message from one mailbox to another in forward_message, the actual STORE method is sent a pointer to the SENDER's vm_state, not the RECEIVER's vm_state.  This patch retrieves a vm_state for the receiver's mailbox and sends that one instead. This patch also calls extern_notify on the receiver's mailbox, which was previously missing.  Let me know if that should be a separate patch.
Comments:	By: Mark Michelson (mmichelson) 2007-07-10 11:41:24 Giving this a scan, I noticed that you have a function call for get_vm_state_by_user. This function doesn't exist in the Asterisk trunk. Is this a function you've written locally? By: James Rothenberger (jaroth) 2007-07-10 13:28:29 This was a local change that is not needed, sorry.  The new patch (v2) does not call that method. By: Mark Michelson (mmichelson) 2007-07-10 14:57:25 Now that I've tried patching my install, I see that "usesmdi" and "smdistation" are not defined and that run_externnotify only takes two parameters. Sorry I didn't point this out sooner. By: James Rothenberger (jaroth) 2007-07-10 15:15:41 My fault.  This version still had a another patch that I have already submitted - (ASTERISK-8796).  v3 has a more standard extern_notify(). By: Digium Subversion (svnbot) 2007-07-10 18:16:09 Repository: asterisk Revision: 74476 ------------------------------------------------------------------------ r74476 | mmichelson | 2007-07-10 18:16:06 -0500 (Tue, 10 Jul 2007) | 5 lines Forwarding a message with IMAP storage was storing the message in the sender's box instead of the forwarded mailbox. (closes issue ASTERISK-9824, reported and patched by jaroth) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-10 18:17:19 Repository: asterisk Revision: 74477 ------------------------------------------------------------------------ r74477 | mmichelson | 2007-07-10 18:17:18 -0500 (Tue, 10 Jul 2007) | 13 lines Merged revisions 74476 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ........ r74476 | mmichelson | 2007-07-10 18:32:52 -0500 (Tue, 10 Jul 2007) | 5 lines Forwarding a message with IMAP storage was storing the message in the sender's box instead of the forwarded mailbox. (closes issue ASTERISK-9824, reported and patched by jaroth) ........ ------------------------------------------------------------------------