|Summary:||ASTERISK-09822: changes ast_exists_extension to function ast_goto_if_exists|
|Reporter:||Patrick Putman (pputman)||Labels:|
|Date Opened:||2007-07-17 16:19:11||Date Closed:||2007-08-07 10:07:30|
|Description:||In three .c files apps/app_parkandannounce.c apps/app_macro.c|
main/pbx.c changes the use of the ast_exists_extension function to use ast_goto_if_exists according to the specifications on the janitor projects page.
|Comments:||By: Tilghman Lesher (tilghman) 2007-07-17 19:54:59|
I think you meant to upload a patch. ;-)
By: Joshua C. Colp (jcolp) 2007-07-18 09:08:11
Just briefly looking at these I would disagree about app_parkandannounce and app_macro. I believe using ast_goto_if_exists would be the wrong thing to use in their cases.
By: Joshua C. Colp (jcolp) 2007-08-07 10:07:28
After looking at all of the spots mentioned I disagree that they should be changed to ast_goto_if_exists. They use ast_exists_extension for a reason.