Summary: | ASTERISK-09804: A ServicelevelPerf value is not initialized correctly. | ||
Reporter: | Noriyuki Suzuki (noriyuki) | Labels: | |
Date Opened: | 2007-07-05 03:49:31 | Date Closed: | 2007-07-05 08:07:56 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_queue |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | QueueParams event packet has a ServicelevelPerf header. This value is not initialized correctly. A sl variable must be set to 0 each time. --- app_queue.c.old 2007-07-05 17:22:11.000000000 +0900 +++ app_queue.c 2007-07-05 17:41:52.000000000 +0900 @@ -4351,6 +4351,7 @@ /* List queue properties */ if (ast_strlen_zero(queuefilter) || !strcmp(q->name, queuefilter)) { + sl = 0; if (q->callscompleted > 0) sl = 100 * ((float) q->callscompletedinsl / (float) q->callscompleted); astman_append(s, "Event: QueueParams\r\n" | ||
Comments: | By: Digium Subversion (svnbot) 2007-07-05 08:02:46 Repository: asterisk Revision: 73315 ------------------------------------------------------------------------ r73315 | file | 2007-07-05 08:02:41 -0500 (Thu, 05 Jul 2007) | 2 lines Reset ServicelevelPerf variable back to 0 if we are unable to calculate it each time... otherwise we will get previous values. (issue ASTERISK-9804 reported by noriyuki) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-05 08:05:36 Repository: asterisk Revision: 73316 ------------------------------------------------------------------------ r73316 | file | 2007-07-05 08:05:35 -0500 (Thu, 05 Jul 2007) | 10 lines Merged revisions 73315 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73315 | file | 2007-07-05 10:19:17 -0300 (Thu, 05 Jul 2007) | 2 lines Reset ServicelevelPerf variable back to 0 if we are unable to calculate it each time... otherwise we will get previous values. (issue ASTERISK-9804 reported by noriyuki) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-05 08:07:12 Repository: asterisk Revision: 73317 ------------------------------------------------------------------------ r73317 | file | 2007-07-05 08:07:11 -0500 (Thu, 05 Jul 2007) | 18 lines Merged revisions 73316 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73316 | file | 2007-07-05 10:22:13 -0300 (Thu, 05 Jul 2007) | 10 lines Merged revisions 73315 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73315 | file | 2007-07-05 10:19:17 -0300 (Thu, 05 Jul 2007) | 2 lines Reset ServicelevelPerf variable back to 0 if we are unable to calculate it each time... otherwise we will get previous values. (issue ASTERISK-9804 reported by noriyuki) ........ ................ ------------------------------------------------------------------------ By: Joshua C. Colp (jcolp) 2007-07-05 08:07:56 Fixed in 1.2 as of revision 73315, 1.4 as of revision 73316, and trunk as of revision 73317. |