Summary:	ASTERISK-09796: RetryDial application doesn't accept 0 for retries
Reporter:	Makoto Dei (makoto)	Labels:
Date Opened:	2007-07-03 01:10:58	Date Closed:	2007-07-03 11:32:25
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Applications/app_dial
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk-1.2.20-RetryDial-0.patch
Description:	The description of RetryDial application says that  If the 'retries' setting is set to 0, this application will retry endlessly. But if 0 is specified for retries, the application fails with the following message.  Jul  3 14:34:00 ERROR[18916]: app_dial.c:1678 retrydial_exec: RetryDial requires the numerical argument <loops> Attached patch will fix the problem.
Comments:	By: Digium Subversion (svnbot) 2007-07-03 07:17:40 Repository: asterisk Revision: 73052 ------------------------------------------------------------------------ r73052 | tilghman | 2007-07-03 07:17:40 -0500 (Tue, 03 Jul 2007) | 2 lines RetryDial should accept a 0 argument, but it does not, because atoi does not distinguish between 0 and error (closes issue ASTERISK-9796) ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-03 07:22:19 Repository: asterisk Revision: 73053 ------------------------------------------------------------------------ r73053 | tilghman | 2007-07-03 07:22:19 -0500 (Tue, 03 Jul 2007) | 10 lines Merged revisions 73052 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73052 | tilghman | 2007-07-03 07:34:14 -0500 (Tue, 03 Jul 2007) | 2 lines RetryDial should accept a 0 argument, but it does not, because atoi does not distinguish between 0 and error (closes issue ASTERISK-9796) ........ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-03 07:23:52 Repository: asterisk Revision: 73054 ------------------------------------------------------------------------ r73054 | tilghman | 2007-07-03 07:23:51 -0500 (Tue, 03 Jul 2007) | 18 lines Merged revisions 73053 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73053 | tilghman | 2007-07-03 07:38:53 -0500 (Tue, 03 Jul 2007) | 10 lines Merged revisions 73052 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73052 | tilghman | 2007-07-03 07:34:14 -0500 (Tue, 03 Jul 2007) | 2 lines RetryDial should accept a 0 argument, but it does not, because atoi does not distinguish between 0 and error (closes issue ASTERISK-9796) ........ ................ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-03 08:57:17 Repository: asterisk Revision: 73099 ------------------------------------------------------------------------ r73099 | phsultan | 2007-07-03 08:57:15 -0500 (Tue, 03 Jul 2007) | 77 lines Merged revisions 72982,72986-72987,73003,73006,73054 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r72982 | russell | 2007-07-03 00:27:46 +0200 (Tue, 03 Jul 2007) | 7 lines * Move LaTeX docs into a tex/ subdirectory of the doc/ dir * Add a Makefile in doc/tex/ for generating PDF and HTML * Add a README.txt file to doc/tex/ to document which tools are used and what  web sites to visit for getting them. * Update build_tools/prep_tarball to put the proper Asterisk version string  in the automatically generated PDF for release tarballs ................ r72986 | russell | 2007-07-03 01:02:16 +0200 (Tue, 03 Jul 2007) | 6 lines After some discussion on the asterisk-dev list, we determined that this approach for extracting application, function, manager, and agi documentation is the wrong one to take.  The most severe problem is that the output depends on which modules are loaded as well as compile time options, which both determine which parts are available. ................ r72987 | qwell | 2007-07-03 04:51:08 +0200 (Tue, 03 Jul 2007) | 4 lines Correct an issue where the wrong type was being used to start sasl. Pointed out by and patch provided by mog. ................ r73003 | tilghman | 2007-07-03 07:21:02 +0200 (Tue, 03 Jul 2007) | 2 lines Typo (closes issue 10105) ................ r73006 | crichter | 2007-07-03 10:22:13 +0200 (Tue, 03 Jul 2007) | 17 lines Merged revisions 73005 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73005 | crichter | 2007-07-03 10:17:06 +0200 (Di, 03 Jul 2007) | 9 lines Merged revisions 73004 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73004 | crichter | 2007-07-03 10:04:35 +0200 (Di, 03 Jul 2007) | 1 line fixed issue, that misdn_l2l1_check could only be called from mISDN Source channels.. ASTERISK-9173 ........ ................ ................ r73054 | tilghman | 2007-07-03 14:40:26 +0200 (Tue, 03 Jul 2007) | 18 lines Merged revisions 73053 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73053 | tilghman | 2007-07-03 07:38:53 -0500 (Tue, 03 Jul 2007) | 10 lines Merged revisions 73052 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73052 | tilghman | 2007-07-03 07:34:14 -0500 (Tue, 03 Jul 2007) | 2 lines RetryDial should accept a 0 argument, but it does not, because atoi does not distinguish between 0 and error (closes issue ASTERISK-9796) ........ ................ ................ ------------------------------------------------------------------------ By: Digium Subversion (svnbot) 2007-07-03 11:32:25 Repository: asterisk Revision: 73125 ------------------------------------------------------------------------ r73125 | tilghman | 2007-07-03 11:32:24 -0500 (Tue, 03 Jul 2007) | 26 lines Merged revisions 73054 via svnmerge from https://origsvn.digium.com/svn/asterisk/trunk ................ r73054 | tilghman | 2007-07-03 07:40:26 -0500 (Tue, 03 Jul 2007) | 18 lines Merged revisions 73053 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 ................ r73053 | tilghman | 2007-07-03 07:38:53 -0500 (Tue, 03 Jul 2007) | 10 lines Merged revisions 73052 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r73052 | tilghman | 2007-07-03 07:34:14 -0500 (Tue, 03 Jul 2007) | 2 lines RetryDial should accept a 0 argument, but it does not, because atoi does not distinguish between 0 and error (closes issue ASTERISK-9796) ........ ................ ................ ------------------------------------------------------------------------