[Home]

Summary:ASTERISK-09780: SayAlpha() and SayPhonetic() fail when encountering unknown symbols, hanging up on the calling channel.
Reporter:Jared Smith (jsmith)Labels:
Date Opened:2007-06-28 13:11:11Date Closed:2007-07-30 15:01:53
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) say_alpha_phonetic-1.4.patch
( 1) say-alpha-unknownchars.diff
Description:For example, if SayAlpha() or SayPhonetic() encounter a comma in the string, they'll exit and hang up on the calling channel.

I've written a patch to simply skip over the offending character and continue on reading more characters.

****** STEPS TO REPRODUCE ******

exten => 123,1,SayAlpha(A)
exten => 123,n,SayAlpha(B,C)

exten => 124,1,SayPhonetic(A)
exten => 124,n,SayPhonetic(B,C)
Comments:By: Jason Parker (jparker) 2007-07-06 13:23:15

How about like that instead?  If it actually fails to play the sound, we do want to hangup, but if the file simply doesn't exist, we're okay.
By: Steve Murphy (murf) 2007-07-20 16:48:25

I'll cast my vote for qwell's version-- the "moment of silence" isn't a big deal, but a full second pause seems a bit too long for me. Just plain skipping it seems better.

I thought about inserting a "beep" instead of silence, but I laugh everytime I think about it. That's not a good sign.  (u r a ,,,!)
By: Digium Subversion (svnbot) 2007-07-30 15:01:53

Repository: asterisk
Revision: 77796

------------------------------------------------------------------------
r77796 | qwell | 2007-07-30 15:01:52 -0500 (Mon, 30 Jul 2007) | 15 lines

Merged revisions 77795 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

(closes issue ASTERISK-9780)
........
r77795 | qwell | 2007-07-30 15:17:08 -0500 (Mon, 30 Jul 2007) | 6 lines

Applications like SayAlpha() should not hang up the channel if you
request an "unknown" character such as a comma.
Instead, skip the character and move on.

Issue 10083, initial patch by jsmith, modified by me.

........

------------------------------------------------------------------------