Summary:ASTERISK-09743: [patch] ast_indicate can be executed on NULL channel
Reporter:Dmitry Andrianov (dimas)Labels:
Date Opened:2007-06-24 17:58:22Date Closed:2007-07-06 19:18:18
Versions:Frequency of
Environment:Attachments:( 0) chanagent.patch
Description:Commit 43307 moved

   ast_indicate(p->chan, AST_CONTROL_UNHOLD);

in the agent_new function outside of if which checked if channel is not NULL. As result, there are circumstances when this function gets called without a channel. (this happens when agent_request creates placeholder and then calls agent_new for it)
Comments:By: Joshua C. Colp (jcolp) 2007-06-24 19:51:16

Fixed in 1.4 as of revision 71412 and trunk as of revision 71413. Thanks!

By: Dmitry Andrianov (dimas) 2007-06-25 03:44:41

Sorry for reopening, I just want to check.

Are you sure that ast_indicate stuff should be under final ELSE? In the revisions prior to 43307 it was under separate IF (exactly as in my patch which just reverts the change). With your fix, ast_indicate will not always be called when it would be called in 43307-1.

By: Joshua C. Colp (jcolp) 2007-06-25 08:04:18

Fixed in 1.4 as of revision 71522 and trunk as of revision 71525. That'll teach me to do bugs while half asleep.