Summary:ASTERISK-09701: [patch] libss7 add support national, international prefix and work with Nature of Address Indicator
Reporter:Mike Anikienko (mike anikienko)Labels:
Date Opened:2007-06-18 05:30:10Date Closed:2007-06-19 10:14:22
Versions:Frequency of
Environment:Attachments:( 0) chan_zap.c.1.diff
( 1) chan_zap.c.diff
( 2) libss7.1.diff
( 3) libss7.diff
( 4) README.diff
( 5) zapata.conf.sample.diff
Description:Many peeple ask why libss7 not support Nature of Address Indicator:
I add this support for libss7.
I test this path with Huawei M900.
Comments:By: Mike Anikienko (mike anikienko) 2007-06-18 06:40:05

Also is added support call presentation.

By: Jason Parker (jparker) 2007-06-18 10:04:20

Congrats on bug number 10000.  You win...absolutely nothing. :)

By: Matthew Fredrickson (mattf) 2007-06-18 11:40:27

I'm still looking through this, but the things that stick out the most to me are as follows:

1.) Make sure you use the existing coding style most prevalent in chan_zap.c.

if () {


if ()

I realize that it's inconsistent in some places, but we don't want to make it any worse, and are striving to make it better.

2.) I would prefer to use this style (as it matches some of the other #defines in libss7.h):


as opposed to:


I'll keep reviewing this, and let you know if I see anything else.  Also, like in your other patch, make sure your indentation is using tabs and follows the existing indentation scheme of the project.

Otherwise, thanks for your work.  These are really useful patches.

By: Matthew Fredrickson (mattf) 2007-06-18 12:08:35

Also, do you mind if I add your switch to the test switch types section in the README file?  Or, if you'd like to you can yourself :-)

By: Mike Anikienko (mike anikienko) 2007-06-18 14:50:51

Formating changed. chan_zap.c.1.diff and libss7.1.diff

By: Mike Anikienko (mike anikienko) 2007-06-18 23:39:01


By: Matthew Fredrickson (mattf) 2007-06-19 10:14:22

Added to trunk.  Thanks Mike Anikienko! :-)