Summary: | ASTERISK-09695: Menuselect won't consider local members as satisfied dependencies | ||
Reporter: | P. Christeas (xrg) | Labels: | |
Date Opened: | 2007-06-17 05:28:16 | Date Closed: | 2011-06-07 14:07:23 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) asterisk-1.4-menuselect.deps.diff | |
Description: | I noticed that eg. res_adsi was missing for app_adsiprog. Still, that was a selected option in menuselect. The attached hack will also consider the entries in categories/members as dependencies that can satisfy the 2nd level of members. Still, this could be incomplete, since this is not a real tree traversal of the dependencies: the 2nd one might fail w/o noticing the 1st. Please comment on that. Am I missing sth in the way these scripts work? | ||
Comments: | By: Russell Bryant (russell) 2007-06-18 10:26:02 I don't really understand what the problem is. Are you saying that app_adsiprog was selected while res_adsi was not? If that's true, I can't seem to reproduce that. Can you figure out what steps you take to get it into that state? By: P. Christeas (xrg) 2007-06-18 10:37:41 The opposite: res_adsi is selected and its dependencies satisfied. There seems to be no 'RES_ADSI' entry in "build_tools/menuselect-deps" and thus 'app_adsiprog' cannot be selected, as if its dependencies are missing. My Q: does the "depend" entry for menuselect look only at the list in "build_tools/menuselect-deps" ? If so, my patch suggests also looking at the data inside menuselect. By: Russell Bryant (russell) 2007-06-18 10:52:45 The menuselect code has two ways of satisfying dependencies. The first is from the menuselect-deps file. The second is by searching the entire tree of members looking for one with that name. For app_adsiprog, it should find res_adsi, see it is enabled, and be happy to let app_adsiprog build. This all works fine for me. If you delete your menuselect.makeopts file, what do you have to do to get it into this state? By: Russell Bryant (russell) 2007-06-18 10:53:37 Also, please update to 1.4.5. There may have been some fixes made since 1.4.4. By: P. Christeas (xrg) 2007-06-18 11:20:55 [please mark as RESOLVED] OK, just realized that menuselect belonged to a different repo. My initial SVN import had just included v.1.4.0 and then never updated ever since. Thanks for your time. |