|Summary:||ASTERISK-09689: [patch] A few code simplifications|
|Date Opened:||2007-06-15 08:56:19||Date Closed:||2007-06-26 11:39:41|
|Environment:||Attachments:||( 0) branch-1.4-jabber_indent_simplification-1.diff|
( 1) trunk-jabber_indent_simplification-1.diff
|Description:||The attached patch simplifies res_jabber by doing the following :|
- more indent where possible
- add a wrapper to iks_start_sasl
Google's jabber server does not accept the base64 computed value within iks_start_sasl fo PLAIN authentication type, as mog saw it before.
****** ADDITIONAL INFORMATION ******
Succesfully tested against Google's jabber server as well as a private jabberd2 jabber server.
|Comments:||By: Jason Parker (jparker) 2007-06-19 13:04:53|
How badly would committing this break your openssl efforts?
By: phsultan (phsultan) 2007-06-20 10:39:27
This patch will indeed conflict with the patch from ASTERISK-9675. I'll update the openssl patch whenever this one gets committed.
By: Jason Parker (jparker) 2007-06-20 10:58:52
Is there any reason this should be put into 1.4? Does it actually fix any bugs? If not, could you upload a patch against trunk?
By: phsultan (phsultan) 2007-06-21 08:52:10
The patch does not fix any bug and just brings code simplifications. Here is a trunk version :)
By: Jason Parker (jparker) 2007-06-26 11:39:41
Committed to trunk in revision 71830.
Thanks! (and this time, I won't forget to karma you) ;)