|Summary:||ASTERISK-09685: [patch] Janitor project convert to ast_debug()|
|Reporter:||Eliel Sardanons (eliel)||Labels:|
|Date Opened:||2007-06-14 19:22:58||Date Closed:||2007-07-06 19:18:18|
|Environment:||Attachments:||( 0) apps.patch|
( 1) log-main-2.patch
( 2) main.patch
|Description:||Related to ASTERISK-9660 and http://firstname.lastname@example.org/msg27376.html|
****** ADDITIONAL INFORMATION ******
/main directory only.
|Comments:||By: Eliel Sardanons (eliel) 2007-06-14 19:23:56|
I would like to know what to do with all the ast_log(LOG_DEBUG,)'s that doesn't check the condition if(option_debug). Thanks
By: Dmitry Andrianov (dimas) 2007-06-15 02:44:54
I have alternative patch :) log-main-2.patch
This is basically second part of main/*.c conversion (I fixed only half of files in 9957 and that issue was cloosed too quickly).
This patch intersects with your a lot but I believe my one is more complete - I also converted all cases with non-trivial conditions like
if (option_debug || rtpdebug)
By: Russell Bryant (russell) 2007-06-22 16:56:57
If there is no check for the condition if (option_debug), I would go ahead and make it ast_debug(1, ...);
By: Dmitry Andrianov (dimas) 2007-06-22 17:01:11
I did exactly that :)
By: Russell Bryant (russell) 2007-06-24 13:50:58
These patches have been merged into trunk in revision 71338, thanks!