Summary:	ASTERISK-09661: Not clearing previously dialed number
Reporter:	anthonyks (anthonyks)	Labels:
Date Opened:	2007-06-12 14:15:17	Date Closed:	2007-06-20 15:54:13
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_skinny
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) 9958-v2.patch ( 1) after_patch_debug.txt ( 2) chan_skinny.c.rej.txt ( 3) debug_only.txt ( 4) extensions_additional.conf ( 5) extensions_custom.conf ( 6) extensions.conf ( 7) Full_debug_snippet.txt ( 8) full.txt ( 9) skinny.conf (10) skinny-clearexten.diff
Description:	Running SVN trunk with patch 9245 (however, i haven't tried a 7935 as of yet... just working on basic functionality). When dialing a number not in the same context as the registered line, I get a fast busy. However, when the phone is hung up, and then another number is tried, the fast busy is immediate. Here's what's going on: Apparently the phone/line/asterisk registers that the line is on hook and changes the state to 1 (Not in use) and hangs up the channel, but when the line is picked up again, it appends whatever digits are dialed to the previously attempted number I've attached the snippet showing the call as well as the full log and the config files.
Comments:	By: Jason Parker (jparker) 2007-06-12 14:29:36 Please try the attached patch, and report back here on whether it works or not. By: anthonyks (anthonyks) 2007-06-12 14:38:54 First try 3 out of 4 hunks failed. I SVN updated from trunk (69013) tried again, 4 out of 4 hunks failed. Attached chan_skinny.c.rej By: Jason Parker (jparker) 2007-06-12 14:56:57 Patch is against 1.4 - should I upload one against trunk? By: anthonyks (anthonyks) 2007-06-12 14:58:09 Naw, I'll do 1.4 here and see what happens. By: anthonyks (anthonyks) 2007-06-12 16:43:09 patch applied to svn 1.4 now i get a constant dial tone after any number of digits. See attached debug snippet. *very similar to bug 9596 (but using a 7940 phone) By: dea (dea) 2007-06-12 18:04:42 The changes are appropriate.  I missed a couple of the memset() calls in my patch to change the channels digit collection logic. This patch correct for both 1.4 and Trunk By: anthonyks (anthonyks) 2007-06-14 09:50:46 I'm confused... are you saying the patch should have worked? Or are you saying "oops i forgot something and i'm working on the new patch to try"?? By: Jason Parker (jparker) 2007-06-14 12:33:05 Hmm, that patch really should have worked.  What were you dialing, and what is that extension defined as in extensions.conf? By: anthonyks (anthonyks) 2007-06-14 14:15:35 Well technically it DID work, but it broke all dialing... no matter what i try to dial now on the phone, it doesn't make asterisk do anything and the dial tone stays on (like the after_patch_debug.txt attachment shows) By: Michiel van Baak (mvanbaak) 2007-06-20 12:31:40 This patch wont apply to my tree. But it's possible that it is because I have patched my tree with 9939 v3 patch and 9762 When I add the memsets manually to chan_skinny at the correct place it fixes the same issue as the OP posted. I vote for inclusion. By: Michiel van Baak (mvanbaak) 2007-06-20 12:36:01 uploaded patch against current trunk. By: Jason Parker (jparker) 2007-06-20 15:54:12 Fixed in svn branches 1.4 and trunk in revisions 70494 and 70495. Any additional issues are likely to be because of the patch in 9245.  Please post feedback there.