[Home]

Summary:ASTERISK-09644: Inband is not working (commented out) for H323
Reporter:Andrius (ndrs)Labels:
Date Opened:2007-06-11 10:06:50Date Closed:2007-06-12 14:48:44
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Channels/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:The inband support is commented out with #if 0 macro. Is there any reasons for that?

I removed the #if directive and am using inband without problems.

****** ADDITIONAL INFORMATION ******

In struct ast_frame *ooh323_rtp_read:

    /* We already hold the channel lock */
3164 :     if (f->frametype == AST_FRAME_VOICE)
3165 :     {
3166 :     if (f->subclass != p->owner->nativeformats)
3167 :     {
3168 :     ast_log(LOG_DEBUG, "Oooh, format changed to %d\n", f->subclass);
3169 :     p->owner->nativeformats = f->subclass;
3170 :     ast_set_read_format(p->owner, p->owner->readformat);
3171 :     ast_set_write_format(p->owner, p->owner->writeformat);
3172 :     }
- 3173 :     #if 0
3174 :     if ((p->dtmfmode & H323_DTMF_INBAND) && p->vad)
3175 :     {
3176 :     f = ast_dsp_process(p->owner, p->vad, f);
3177 :     if (f && (f->frametype == AST_FRAME_DTMF))
3178 :     ast_log(LOG_DEBUG, "* Detected inband DTMF '%c'\n",f->subclass);
3179 :     }
- 3180 :     #endif
3181 :     }
Comments:By: Russell Bryant (russell) 2007-06-12 14:48:44

It is now uncommented in trunk revision 395.  thanks!