[Home]

Summary:ASTERISK-09630: fskmodem and tdd lack documentation of proper use...
Reporter:Don Fanning (donfanning)Labels:
Date Opened:2007-06-08 22:05:38Date Closed:2011-06-07 14:08:12
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Documentation
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:In reviewing the code, I'm looking at fskmodem.c and tdd.c but when I go to DOxygen, there is little rhyme or reason as to why you would even have this code in there.

Understandably, fskmodem.h interfaces with callerid.c to decode 1200FSK on Zap lines but there's really no encoder there to speak of.  That code resides in callerid.c.  The tdd.c has the code to take the raw audio and decode/encode the BAUDOT of the stream but lacks any sort of interface outside the function.  

Where does one take advantage of the tdd.c/.h code and interface it outside Asterisk to a terminal or even external scripts?

The docs don't even show how it can be utilized effectively under AEL.

Does anyone have some insight to it?

Incidently, isn't there a better way of taping the raw audio out of asterisk into some DSP code for better MF/DTMF/DATA support?

----
Reproduction:

Want to send TDD messages to callers via AEL.
Open documentation.
Find nothing there relating to TDD.
Cry because it's not documented yet the code exists.
Log into mantis to bitch and moan.
Rinse and repeat.
---
Comments:By: Jason Parker (jparker) 2007-06-12 16:19:44

Asking for documentation would technically be a feature request (I'm being a bit picky, but see below).  If you would like to make a patch to explain how it works, we would be more than happy to commit it.  You can also request on the asterisk developers mailing list whether somebody who knows how it works would be willing to contribute documentation fixes.  If you or somebody else does get a patch, please feel free to reopen this report.

I'm going to close this, because frankly, there are probably only a handful of people who understand enough about how it works to be able to explain it properly.