[Home]

Summary:ASTERISK-09628: [patch] log_debug
Reporter:Dmitry Andrianov (dimas)Labels:
Date Opened:2007-06-08 20:04:35Date Closed:2007-07-11 19:59:24
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) 1-log-include.patch
( 1) 1-log-main-pbx.patch
Description:As discussed on asterisk-dev, here is the proposed patch, it adds ast_debug macro which basically test status of option_debug and calls ast_log.

****** ADDITIONAL INFORMATION ******

only main/pbx.c is patched at the moment (as a proof of concept). Will create patch for rest of files (and for 1.4 branch if required) if you are ok with this one.

The patch is for trunk @ 68574 (note that chan_misdn does not build in revision 68574 but that is not caused by this patch)
Comments:By: Tilghman Lesher (tilghman) 2007-06-10 20:44:00

We'll need you to file a disclaimer before we can merge this.

By: Dmitry Andrianov (dimas) 2007-06-11 09:21:29

faxed.

what is next? make patches for other files? tunk is enough or should i create two set of patches - one for tunk and another for 1.4 branch?

By: Tilghman Lesher (tilghman) 2007-06-11 10:38:48

Given that this is a new API, it is only a candidate for trunk.

By: Russell Bryant (russell) 2007-06-12 11:14:27

I have added the new macro as well as your conversion of pbx.c to trunk in revisions 68987 and 68991.  Feel free to create new tickets if you are interested in converting other files.  Thank you!