Summary:ASTERISK-09578: C++fication of channels/*.c
Reporter:Dmitry Andrianov (dimas)Labels:
Date Opened:2007-06-03 16:44:25Date Closed:2007-06-04 06:21:34
Versions:Frequency of
Environment:Attachments:( 0) cppkw-channels-branch14.patch
( 1) cppkw-channels-trunk.patch
Description:http://bugs.digium.com/view.php?id=9830 says "The two instances you pointed out have been fixed in 1.4 and trunk in revisions 66775 and 66776. If you find any more, please report another bug. Thanks!"

I have renamed all variables named "new" in channel/*.c. Patches for 1.4 branch and trunk attached.


By the way, "new" seems to be very popular name - there are many renamings still pending (especially in main/*)
Comments:By: Tilghman Lesher (tilghman) 2007-06-03 19:18:25

I don't think there's a need to change source files for variable names -- only APIs which may get called by C++ modules.  The general source will still be compiled by a native C compiler.

By: Russell Bryant (russell) 2007-06-03 19:24:57

I agree with Corydon76 here.  There is no reason to change the code itself that is explicitly C.  The only pieces that must stay C++ friendly are the APIs that might be used by C++ modules.

By: Dmitry Andrianov (dimas) 2007-06-04 03:11:53

Close it then. Misunderstanding.

By: Joshua C. Colp (jcolp) 2007-06-04 06:21:33

Closed per discussion/request.