Summary:ASTERISK-09558: [patch] app_minivm.c code cleanup and not needed LOCKs/frees
Reporter:Eliel Sardanons (eliel)Labels:
Date Opened:2007-05-31 11:29:25Date Closed:2007-07-11 19:59:07
Versions:Frequency of
Environment:Attachments:( 0) app_minivm.c.patch
Description:AST_LIST_EMPTY() is no needed while traversing a list (its already being checked in LIST_TRAVERSE()...

We don't need to free structures prior to calling load_config() because they are being free there.

Use the programmed functions for freeing the minivm structures and the coded free_zone function too.
Comments:By: Russell Bryant (russell) 2007-05-31 12:58:08

Added to trunk in revision 66772.  Thanks!

I have one small suggestion for you.  Run the ./configure script with the option --enable-dev-mode on your development machine.  This does a few things, but most importantly, asks the compiler to treat warnings as errors so you don't accidentally miss them.  There were a few unused variables left after applying this patch.