Summary:ASTERISK-09501: [patch] Imap storage voicemail as gsm have duplicate attachments, whereas other formats have one.
Reporter:xmarksthespot (xmarksthespot)Labels:
Date Opened:2007-05-23 15:46:26Date Closed:2007-06-01 16:20:29
Versions:Frequency of
Environment:Attachments:( 0) app_voicemail_fixed_branch.c
( 1) app_voicemail_fixed_trunk.c
( 2) tobranchrev65501.diff
( 3) totrunkrev65659.diff
Description:I think this is borderline trivial, but I prefer to put it as minor as it's just an annoyance.

When format is set to "gsm" in voicemail.conf with imap storage enabled, the messages sent have duplicate "gsm" attachments. I've narrowed it down to the exact place in the code that causes this, and created a patch for branch and trunk.

Thing is I am semi-certain about the patch, but what I do know is that removing the lines I removed clears the problem straight up, and messages are attached in a consistent way, i.e. only one attachment.


This is borderline trivial, and just an annoyance or a "what the" thing, but I felt I should mention it and fix it anyway.

I've tested it, and it doesn't seem to break anything. From the looks of it the condition of the "if" never happens in the intended way. I've had similar problems while testing code, but I am unsure as to why.

If I broke anything please tell me, as my system works fine without this.
Comments:By: xmarksthespot (xmarksthespot) 2007-05-23 15:49:22

If you need a disclaimer please ask, I'll send it for 9786 and this one.

By: xmarksthespot (xmarksthespot) 2007-05-24 14:14:26

I sent in a disclaimer for 9786 so I guess I should mention it here too.

By: Mark Michelson (mmichelson) 2007-06-01 15:59:45

I reproduced this issue and tested your patch. It appears to work properly. I will be committing it soon.

Thank you very much for submitting a patch and helping with this IMAP stuff!

By: Mark Michelson (mmichelson) 2007-06-01 16:18:33

I'm closing this now. xmarksthespot's patch fixes this problem. I also am closing issue 8873.

Once again, thank you very much for your patch.

By: Mark Michelson (mmichelson) 2007-06-01 16:20:29

This bug is fixed in 1.4 in SVN revision 66897.
Also fixed in trunk in SVN revision 66910.
A duplicate issue, 8873, is also resolved due to this patch.