[Home]

Summary:ASTERISK-09455: authuser setting for imap storage does not work properly and prevents master user
Reporter:xmarksthespot (xmarksthespot)Labels:
Date Opened:2007-05-16 12:03:37Date Closed:2007-07-11 19:58:56
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) app_voicemail_patched_trunk.c
( 1) difftotrunk.diff
( 2) difftotrunk-proper.diff
( 3) patch.diff.txt
Description:In Asterisk 1.4.4, master user login is broken. This is due to the way that the authuser setting is passed on to the cclient for login.

I believe the connection string is incorrect. The connection string that asterisk passes works neither with mtest nor pine. It is not standard UW IMAP spec either.

For example, authenticating to a Dovecot server with a master user whose user name is masterusername, with no TLS, to access the mailbox of jdoe, Asterisk would send this string:

{localhost:143/imap/masterusername/notls/user=jdoe}

This string will not work with mtest nor pine.

The correct string to send would be:

{localhost:143/imap/authuser=masterusername/notls/user=jdoe}

I have "repaired" the authuser setting in voicemail.conf with a nasty trick:
for the same example as above, simply use authuser=authuser=masterusername.

Tried it and it works.

I tracked down the place where it happens in app_voicemail.c, and created a small patch for trunk.

****** ADDITIONAL INFORMATION ******

I tracked down where the string is made in app_voicemail.c and changed the line so that it adds "authuser=" in front of the master username.

I am submitting a modified version of app_voicemail.c of trunk with this fixed, and also a diff to trunk.

I R N00B with diff! Handle with care!

I'm really not a very good programmer, but it works now, and besides it's a trivial fix.

Do I really need a disclaimer for this, it's just a couple characters?

I can also diff to 1.4.4 for everybody.

Thanks.
Comments:By: xmarksthespot (xmarksthespot) 2007-05-16 12:04:58

Please delete the .diff.txt file, I'm an idiot.

I'm adding a diff to trunk file.

I'll add a diff to 1.4.4 soon (maybe).

Heh my patch doesn't respect the proper file hierarchy to boot.

Guess I deserve a couple of WTFs now.


By: xmarksthespot (xmarksthespot) 2007-05-16 15:07:58

I think I might have repaired the patch to trunk, the new and probably valid file is difftotrunk-proper.diff.

Sorry for the trainwreck this thing is turning out to be.
By: xmarksthespot (xmarksthespot) 2007-05-16 15:47:22

Not sure how to diff to 1.4.4. Can someone help me?

I fixed my own stuff but I need to let people be able to fix their machines too!
By: Joshua C. Colp (jcolp) 2007-05-17 08:50:34

Fixed in 1.4 as of revision 64720 and trunk as of revision 64721. Thanks!