[Home]

Summary:ASTERISK-09417: [patch] KB1EC Timed Agressive Cancellation
Reporter:Stephen Marron (soloflyer)Labels:
Date Opened:2007-05-10 07:01:35Date Closed:2007-05-17 12:17:51
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) agtime.diff
( 1) agtime.kb1.mg1.diff
( 2) agtimesvn.diff
( 3) agtimesvn.kb1.diff
( 4) agtimesvn.mg2.diff
Description:Allows use of the aggressive echo cancelation for the amount of time defined by AGGRESSIVE_TIMELIMIT in kb1ec_const.h (if not defined it just does aggressive forever) after the set period of time has elapsed the non-aggressive echo canceling is used


if ( Time_Elapsed < AGGRESSIVE_TIMELIMIT ) {
  Aggressive_Cancelation();
}
else {
  Standard_Cancelation();
}

its very very simple... but it works very very well :)

I wrote a similar thing Previously for Mec2 echo can... see bug 0004823
Comments:By: Jason Parker (jparker) 2007-05-10 11:10:03

Since this is a new feature, it can only go into trunk.  Having said that, I think this is a good addition.

Can you make this work on zaptel trunk, and upload a new patch?
By: Stephen Marron (soloflyer) 2007-05-11 00:38:40

agtime.diff already applied cleanly to SVN Trunk but i have uploaded agtimesvn.diff which is a svn diff :)
By: Stephen Marron (soloflyer) 2007-05-11 00:55:34

I have made the same changes to MG2 so that this patch can be used with that echo can

agtimesvn.kb1.diff <-- SVN Diff for KB1ec
agtimesvn.mg2.diff <-- SVN Diff for MG2ec
By: Jason Parker (jparker) 2007-05-11 11:59:22

These don't actually apply to trunk for me.  Can you verify, and upload new patches?  (You should actually just go ahead and put them both into one patch - it'll make it easier for all parties, since this patch is so small)


root:/usr/src/zaptel/trunk# patch -p0 --dry-run < file_download.php\?file_id\=14008\&type\=bug
patching file mg2ec_const.h
patching file mg2ec.h
Hunk #1 FAILED at 556.
Hunk #2 FAILED at 570.
Hunk #3 FAILED at 594.
3 out of 3 hunks FAILED -- saving rejects to file mg2ec.h.rej
root:/usr/src/zaptel/trunk# patch -p0 --dry-run < file_download.php\?file_id\=14007\&type\=bug
patching file kb1ec_const.h
patching file kb1ec.h
Hunk #1 FAILED at 435.
Hunk #2 FAILED at 449.
Hunk #3 FAILED at 473.
3 out of 3 hunks FAILED -- saving rejects to file kb1ec.h.rej
root:/usr/src/zaptel/trunk#
By: Stephen Marron (soloflyer) 2007-05-13 06:14:33

soo children what did we learn today....

never copy/paste from a ssh session into a text file!

sorry about that...

agtime.kb1.mg1.diff - both patches in one file based off current svn copied using scp and NOT using copy/paste... :)
By: Jason Parker (jparker) 2007-05-17 12:17:50

Added to svn trunk in revision 2526.

Thanks :)