Summary:	ASTERISK-09402: chan_h323 from svn branch 1.2 will not compile
Reporter:	Cesc Santasusana (cescsanta)	Labels:
Date Opened:	2007-05-08 11:15:06	Date Closed:	2007-05-09 12:03:53
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_h323
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) asterisk.1.2.18.svn63330.h323.patch
Description:	The makefile is not good See attached patch (actually, the makefile from a previous version).
Comments:	By: Jason Parker (jparker) 2007-05-08 11:48:52 What errors are you actually getting? By: Cesc Santasusana (cescsanta) 2007-05-08 16:55:56 Something in the line of: "opt not found" ... Sorry I cannot be more specific ... By: Brandon Kruse (bkruse) 2007-05-08 19:58:58 I hope no one commits this Patch. The main thing it does is change the path of his home directory. Cescsanta, instead of making it a hardcoded path, find one why the $(HOME) variable is not getting set, if that is even the problem, which I doubt it is. -bkruse By: Cesc Santasusana (cescsanta) 2007-05-09 04:13:19 Hi, Of course the patch is not directly to be committed, but it is to give an idea of what I had to change to get things to compile. If you read my report, you'll see that I basically used the Makefile from version 1.2.9.1 ... so my suggestion is to revert to that one. Forget my setting of OPENH323DIR to where I actually have my openh323 compiled ... focus on the other changes the patch shows: - definition of OBJS and TARGET - always including openh323u.mak - maybe the clean target can be left in the Makefile ... but it was colliding with the clean from openh323u.mak ... - the "include $OPENH323DIR/openh323u.mak" in the libchanh323.a target was telling me "error: include command not known" ... By: Cesc Santasusana (cescsanta) 2007-05-09 07:31:23 BTW, there is a user on the mail list with the same problem, I told him about what I had done, he did it, took the Makefile from 1.2.13 (or so he reports) and the chan_h323 compiled just fine ... Best regards, Cesc By: Paul Cadach (pcadach) 2007-05-09 12:03:52 You are trying to backport changes made in 1.4 tree into 1.2 tree. Because there are huge chan_h323 differences between 1.4 and 1.2 versions, better is to switch to 1.4 version of Asterisk instead of backporting 1.4 to 1.2 and making 1.2 to be as 1.4. chan_h323 in 1.2 is not so stable and clean as in 1.4, so using 1.2 with chan_h323 will bring many different sorts of deadlocks, cores, etc. Regarding attached patch - you should set global environment variable named OPENH323DIR with its value equal to /xtd/cafes/asterisk.trunk/openh323, add chan_h323.so into CHANNEL_LIBS in channels/Makefile, and you will get the same results as with your patch. Because chan_h323 in 1.2 is unstable, nobody will include it into module list to be built by default.