Summary:ASTERISK-09328: Enhance app_meetme RealTime capabilities
Reporter:dea (dea)Labels:
Date Opened:2007-04-26 18:18:31Date Closed:2007-10-17 15:26:55
Versions:Frequency of
Environment:Attachments:( 0) 20070906__bug9609.diff.txt
( 1) app_meetmme-rt-diff.txt
( 2) app_meetmme-rt-trunk.txt
( 3) CHANGES-RealTime-app_meetme.txt
  Make column names configurable. (defaults to original hardcoded names)
  Make DB logging for participant count optional (defaults to on to be compatible with current behaviour)
  Add optional schedule feature  (defaults to off)
     If using secheduling add optional features to
     alert the caller if they are early, or to allow
     the caller to start the conference early.
     (audio file for the early announcment, as recorded by
      Alison can be provided)


  Impliment a conference 'watchdog' to end the conference at the
  scheduled time.
  Fixup parsing/setting conference options based on Admin/User

With all of the new options set to their defaults, app_meetme behaves
as before the patch.

With the schedular turned on, the code will first look for an existing
conference, then a static conference, finally a RealTime stored conference.

The majority of changes occured in find_conf_realtime() and load_config().
Making the logging of participant count option required small changes
in other parts of the code, and a couple small changes in conf_exec to handle
the case of an early caller.

Comments:By: dea (dea) 2007-06-11 12:54:57

Added support for ending a conference at a scheduled time and enforcing
participant count.

The implimentation of setting and ending a conference endtime is a tad
ugly, or at least that is what I expect the reaction to be.  It works,
but if it is too hideous to live I will rework it (hints please)

By: Tilghman Lesher (tilghman) 2007-09-10 14:23:57

I have reworked the patch.  In particular, I've made the following changes:
1) I have removed the capability of changing field names.  They are what they are and do not need to be customizable.  After all, the fields should be particular to Asterisk.  If someone needs to merge from an existing table for Asterisk, they should use a view.
2) I have made API changes, mostly to make this patch thread-safe.  In particular, localtime() is not thread-safe.
3) Patch is against trunk, as we do not add new features to a branch already in a release cycle.

By: dea (dea) 2007-09-10 16:17:30

Thanks for looking at this.

1)  I like flexibility, and makeing the fields customizable seemed reasonable,
but I also can see your point and do not have a problem with requiring views
if the names do not mesh.

2)  I'll keep these changes in mind for future efforts

3)  Agreed and understood.  When and where reasonable, I like to offer patches
for both Trunk and the current release, hoping to get more testing and feedback.
I would not expect it to be merged anywhere but Trunk.

Oh and your updated patch has both startTime and starttime.  I assume you
prefer the latter...

By: dea (dea) 2007-09-11 11:40:52

Just a quick follow up on views.  There is a good number of installations
using Web-MeetMe, which provides a web interface for scheduling and a
database backend.

The column names do not match up perfectly with what RealTime app_meetme
would use.  The majority of the installations are likely to be on older
MySQL installs that do not support views.

When this is merged, and 1.6 is branched for release, I can produce an
upgrade for Web-MeetMe that will include tools to rename the columns for
existing installations.  It will make parallel installations for testing
difficult, but such is life.

The Web-MeetMe suite has also been picked up by a number of the Asterisk

So I am back to prefering that the column names be customizable, not to
make my life easier, but to simplify things for users of Asterisk who also
use Web-MeetMe.

By: Digium Subversion (svnbot) 2007-10-17 09:53:06

Repository: asterisk
Revision: 86065

U   trunk/apps/app_meetme.c

r86065 | tilghman | 2007-10-17 09:53:05 -0500 (Wed, 17 Oct 2007) | 2 lines

Enhancements to realtime (closes issue ASTERISK-9328)


By: Tilghman Lesher (tilghman) 2007-10-17 13:12:24

Reopened by request of reporter

By: dea (dea) 2007-10-17 13:44:51

Documentation for CHANGES uploaded.  There is a small cosmetic issue
with the merged patch-
  one variable has mixed case, while all others are lower case

I'd also like to discuss entry 0070336, re: use of views compared
to configurable column names.  I can take that to the -dev list
if prefered.

By: Tilghman Lesher (tilghman) 2007-10-17 15:26:55

Okay, change committed.  Yes, the -dev list is the proper forum for that discussion.