Summary: | ASTERISK-09308: Code doesn't seem to use ani | ||
Reporter: | P. Christeas (xrg) | Labels: | |
Date Opened: | 2007-04-25 03:01:18 | Date Closed: | 2007-07-09 21:20:52 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Channels/chan_zap |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | When reading the code to understand how ANI works for zapata PRI lines, I came accross the following lines: diff --git a/channels/chan_zap.c b/channels/chan_zap.c --- a/channels/chan_zap.c +++ b/channels/chan_zap.c @@ -5287,7 +5287,7 @@ static struct ast_channel *zt_new(struct zt_pvt *i, int state, int sta rtpbx, int tmp->cid.cid_num = ast_strdup(i->cid_num); tmp->cid.cid_name = ast_strdup(i->cid_name); if (!ast_strlen_zero(i->cid_ani)) - tmp->cid.cid_ani = ast_strdup(i->cid_num); + tmp->cid.cid_ani = ast_strdup(i->cid_ani); else tmp->cid.cid_ani = ast_strdup(i->cid_num); #else .. The removed line, IMHO, just doesn't look right! Shouldn't it be like the inserted one? | ||
Comments: | By: Russell Bryant (russell) 2007-04-25 11:23:11 You are correct. Nice catch! This change has been made in 1.2, 1.4, and trunk in revisions 61798, 61799, and 61800. Thanks! |