Summary: | ASTERISK-09219: app_queue with MixMonitor does not honor MONITOR_EXEC unless MONITOR_OPTIONS is set | ||
Reporter: | Charles Duffy (cduffy) | Labels: | |
Date Opened: | 2007-04-07 02:51:04 | Date Closed: | 2007-07-09 21:20:47 |
Priority: | Minor | Regression? | No |
Status: | Closed/Complete | Components: | Applications/app_queue |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ||
Description: | The following code is used (in both 1.4.2 and trunk r60658) to invoke the MixMonitor app: if (!ast_strlen_zero(monitor_exec) && !ast_strlen_zero(monitor_options)) snprintf(mixmonargs, sizeof(mixmonargs)-1, "%s|b%s|%s", tmpid2, monitor_options, monitor_exec); else snprintf(mixmonargs, sizeof(mixmonargs)-1, "%s|b%s", tmpid2, monitor_options); This means that monitor_exec is not passed in to MixMonitor unless monitor_options is also specified. This is unfortunate, as monitor_exec is meaningful even without monitor_options. ****** ADDITIONAL INFORMATION ****** The obvious fix is to chop off the second clause of the conditional, such that if (!ast_strlen_zero(monitor_exec) && !ast_strlen_zero(monitor_options)) becomes if (!ast_strlen_zero(monitor_exec)) | ||
Comments: | By: Joshua C. Colp (jcolp) 2007-04-08 12:14:05 Fixed in 1.4 as of revision 60762, and trunk as of revision 60763. Thanks! |