Summary:ASTERISK-09163: [patch] parse_uri function chokes on some URIs
Reporter:vadim (vadim)Labels:
Date Opened:2007-04-01 08:02:37Date Closed:2007-06-30 09:20:15
Versions:Frequency of
Environment:Attachments:( 0) issue9439.patch
( 1) parse-rfc4504-uri.patch
( 2) parse-rfc4504-uri-forast1.4.2.patch
Description:Following uri is not correctly parsed
because of ';' is before of '@'

Read http://article.gmane.org/gmane.comp.telephony.pbx.asterisk.devel/24253
for further info

The attached patch corrects parse_uri function to correctly handle the case

Comments:By: Russell Bryant (russell) 2007-04-04 11:55:16

I thought this problem had already been fixed.  Also, this patch appears to be changing code that doesn't exist ...

Can you please verify that your patch is up to date and that it applies cleanly to the current code so that I can see what you're trying to change?

By: Russell Bryant (russell) 2007-04-04 11:56:30

Oh, I see.  This patch is against code in trunk, not 1.4.  The description was incorrect.

By: Serge Vecher (serge-v) 2007-04-05 08:14:56

vadim: can you please make a patch against 1.4 svn?

By: Russell Bryant (russell) 2007-04-05 14:10:52

serge-v: The patch addresses code that only exists in trunk.

By: vadim (vadim) 2007-04-06 09:48:43

I'm attaching backport of my patch against 1.4.2,
ATTN:  untested

By: Olle Johansson (oej) 2007-05-02 02:08:49

Ok, can you tell me in which scenario this is not correctly parsed? In INVITEs, REGISTER requests? I need to look into 1.2 and 1.4 properly and fix this, but need to know where it fails for you in trunk so I can test the same scenario.

By: Olle Johansson (oej) 2007-05-02 02:18:55

For the issue reported in ASTERISK-9285, having a ;parameter part in the username part of the Contact uri, I'm attaching a patch.

GEISJ: Please test and confirm if it solves your issue.

By: Olle Johansson (oej) 2007-05-02 04:41:28

Another patch committed to svn trunk, that fixes this issue in a few more places. Please test.

By: Olle Johansson (oej) 2007-05-02 04:41:55

Rev 62640 btw... :-)

By: Olle Johansson (oej) 2007-05-09 08:52:33

Waiting for feedback

By: Olle Johansson (oej) 2007-05-16 04:53:41

I would really appreciate some feedback here. Thanks.

By: Olle Johansson (oej) 2007-05-16 04:57:25

Committed patch earlier to trunk, now also to 1.4 rev 64565

If you have more issues or if this doesn't fix it, please reopen.