Summary:ASTERISK-09149: [PATCH] Send a correct version number for Manager Connection
Reporter:Matt Riddell (zx81)Labels:
Date Opened:2007-03-30 00:38:37Date Closed:2007-04-30 11:52:55
Versions:Frequency of
Environment:Attachments:( 0) manager.patch
Description:The format of a few manager commands have changed and there is no way to tell what version you've connected to except through testing manager commands.

Basically the patch is just to change 1.0 to 1.4, although it should probably be set to 1.2 for the 1.2 branch and 1.6 in SVN-trunk.
Comments:By: Clod Patry (junky) 2007-03-30 00:41:02

+1 for me.

By: Matt Riddell (zx81) 2007-03-30 00:41:06

I don't mind making this change when the major version number changes as we need it for in house software too.

By: Serge Vecher (serge-v) 2007-03-30 08:49:12

I recall there was a discussion on the dev list to this effect a couple of months ago. Did that reach any sort of agreement?

By: Matt Riddell (zx81) 2007-03-30 16:59:44

I was under the assumption it was agreed something needed to change.

I.E. If I connect to a manager inferface (not knowing the Asterisk version), and do a show channels concise, in 1.2 I will get values delimited by "," and in 1.4, values delimited by "!".

The version has been 1.0 forever, so nobody is currently parsing it.

We discussed in in #asterisk-bugs yesterday and it was decided that it should change just by major version number.

You can get the full version information by "command: show version", but there are so many different ways of presenting this information that it becomes difficult to parse.

When the discussion on the dev list happened, it was agreed that if the Asterisk manager changed in any way that wasn't backwards compatible, the version number should increase.  It has done this., althought the number hasn't changed.

By: Matt Riddell (zx81) 2007-04-27 18:46:09

Any word on this?

By: Russell Bryant (russell) 2007-04-30 11:52:07

I think it has pretty much been decided that this version number will represent protocol version, not Asterisk version.  It hasn't been updated in the past as much as it probably should have (or all), but hopefully that will get better.

There is logic behind the information you get with "show version" so this should be plenty good enough for what you need.  If it is from a release tarball, it will be the exact release number.  If it came from SVN, it will have an "SVN-" prefix, and then it will indicate which branch it came from, and the revision number.  This format will not change.

By: Russell Bryant (russell) 2007-04-30 11:52:55

Of course, if you would like to discuss this further, feel free to bring it up on the asterisk-dev mailing list.