Summary:	ASTERISK-09049: Make logging Unique ID a config option, rather than a compile option
Reporter:	Eric Caron (ecaron)	Labels:
Date Opened:	2007-03-19 14:50:25	Date Closed:	2007-06-08 16:21:30
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) cdr_addon_mysql.svn.diff
Description:	The ability to log each unique id should be a configuration change and not require a recompilation of asterisk-addons. The attached diff file changes cdr_addon_mysql.diff and reads a "loguniqueid" flag from cdr_mysql.conf and uses that value, instead of a def from the .c file. Valid entries for cdr_mysql.conf include: loguniqueid=yes (or 1, or true) loguniqueid=no (or 0, or false) If loguniqueid isn't set in cdr_mysql.conf, the uniqueid isn't logged.
Comments:	By: Serge Vecher (serge-v) 2007-03-19 15:03:01 can you please get a disclaimer on file and redo the patch with "svn diff" command? By: Eric Caron (ecaron) 2007-03-19 17:47:37 New diff (cdr_addon_mysql.1.svn.diff) has been thoroughly tested and works great. I hope this gets included. I feel that it is a very important modification to allow users to quickly de/activate the uniqueid feature. By: Serge Vecher (serge-v) 2007-03-20 08:32:36 go ahead and send a disclaimer in to kpflemming at digium.com noting this bug #. By: Eric Caron (ecaron) 2007-03-21 12:18:40 serge-v, can you delete the first 2 attachments? Only "cdr_addon_mysql.1.svn.diff" should be attached. By: Eric Caron (ecaron) 2007-04-28 14:27:40 Can we get people to test this to be included in 1.4.5? By: Eliel Sardanons (eliel) 2007-06-03 22:15:54 I didn't have time to test this issue but I have one suggestion, use ast_true() instead of this if statement: if ((strcmp(tmp,"false") != 0) && (strcmp(tmp,"no") != 0)) { By: Eric Caron (ecaron) 2007-06-05 13:02:05 Please delete "cdr_addon_mysql.1.svn.diff" New .diff file incorporates ast_true, cleans up some nested if-statements, improves debug and makes error messages more consistent. I strongly believe this should be included in addons 1.4.2. By: Russell Bryant (russell) 2007-06-08 16:21:30 This functionality has been merged into trunk in revision 393.  Thanks!