Summary:	ASTERISK-09039: [patch] Only apply externip on SIP, not on media streams
Reporter:	Erik Tornstam (tornstam)	Labels:
Date Opened:	2007-03-17 11:17:57	Date Closed:	2011-06-07 14:02:38
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Addons/General
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chan_sip.c.patch
Description:	In a loadbalanced enironment you can use externip to set the loadbalancers ip in sip messages. Unfortunately enough this allso changes the ip address for the RTP stream which you don't want to go trough the loadbalancer. This patch gives you the possibility to use the real ip for rtp. Set useexternrtpip=no in sip.conf
Comments:	By: Olle Johansson (oej) 2007-03-18 15:45:09 Please read the bug guidelines before opening an issue report. 1) YOu have no disclaimer on file, which means we can't look at this at all 2) You have submitted a patch to a very old release. Patches for new functions    should be against svn trunk 3) There are similar patches in the bug tracker - you haven't checked properly Start with fixing the disclaimer part, then we'll start working on the rest. Thanks for contributing to Asterisk! /O By: Erik Tornstam (tornstam) 2007-03-21 05:19:43 Disclaimer faxed to digium. By: Serge Vecher (serge-v) 2007-03-21 09:06:35 ok, next step is to create a patch against trunk. By: Olle Johansson (oej) 2007-04-30 02:16:32 Please don't use a string to store a binary value... Try again! I think this is a good patch. The name might need to change to something that more easily connects to externip. "externip-rtp" or along that line... By: Olle Johansson (oej) 2007-05-15 15:27:43 Any updates? By: Olle Johansson (oej) 2007-05-16 02:51:43 This logic needs to be implemented in the get_our_media_address() function instead. By: Tilghman Lesher (tilghman) 2007-11-06 20:17:13.000-0600 No response from reporter.  Please reopen if/when you have a new patch to upload.