[Home]

Summary:ASTERISK-09032: [patch] disable building codec_zap for zaptel older than 1.2.13
Reporter:Tzafrir Cohen (tzafrir)Labels:
Date Opened:2007-03-16 12:11:51Date Closed:2007-06-21 17:04:39
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) ast_12_nozapnodec.diff
Description:Support for codec_zap has been originally added to Asterisk 1.4 with some interface extensions to zaptel in order to support this. It has later been backported to 1.2 of both.

As a result, later versions of Asterisk 1.2 branch (According to reports on asterisk-users: as of around rev. 53132) fail to build when Zaptel is older than 1.2.13. This forces users to reinstall zaptel in order to upgrade Asterisk.

The patch checks for the presence of a certain define in zaptel.h as a condition for building codec_zap.so .

****** ADDITIONAL INFORMATION ******

The patch is for 1.2 and not tested.

For 1.4 and trunk it should be handled through a autoconf test as that is more relieble (Is this already the case?)
Comments:By: Serge Vecher (serge-v) 2007-03-16 12:19:55

my feeling is that we should encourage people to update Zaptel to the latest release when Asterisk is being updated.
By: Tzafrir Cohen (tzafrir) 2007-03-16 12:33:22

From what I understand, Asterisk 1.2 should build with Zaptel 1.2 and a new version of Asterisk should not require a new version of Zaptel.

Recall that the interface here changed due to an addition of a feature (the new codec interface), not fixing of a bug.
By: Serge Vecher (serge-v) 2007-03-16 12:36:37

"Asterisk 1.2 should build with Zaptel 1.2", I'm not sure that's the guarantee, I think it is latest asterisk release with the latest zaptel one. Well, it's up to maintainers to decide.
By: Russell Bryant (russell) 2007-06-21 17:04:38

I don't want to make it any easier for people to use old versions of Zaptel.  Updated versions have driver fixes, so we should do everything we can to encourage people to update.