| Summary: | ASTERISK-08984: [patch] User attributes in From tag | ||
| Reporter: | Curt Moore (jcmoore) | Labels: | |
| Date Opened: | 2007-03-09 17:36:04.000-0600 | Date Closed: | 2007-06-30 09:20:08 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_sip/Interoperability |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) from_argument_fix.diff.txt | |
| Description: | While doing some interop testing with a PSTN provider, I found that chan_sip is not properly discarding arguments in the From SIP header. ****** ADDITIONAL INFORMATION ****** Example, if the From header is constructed like: <sip:8164444422;phone-context=+1@1.2.3.4:5060;user=phone;tag=SDadkoa01-gK0c3bdb43 The "phone-context=+1" argument portion of the From header was not being discarded. In this case, "8164444422;phone-context=+1" was being taken and set as the callerid number in check_auth_result check_user_full() instead of just plain "8164444422". The attached patch trims off any arguments in the username portion of the From header. | ||
| Comments: | By: Olle Johansson (oej) 2007-03-12 03:45:16 I thought this was already fixed. Hmm. Will check. By: Curt Moore (jcmoore) 2007-03-12 10:27:45 I believe the same thing was happening with attributes in the Request URI a while back and that was fixed. I do not think that this has been an issue until now in the From header. By: Olle Johansson (oej) 2007-03-13 04:07:37 Yes. We only fixed this in the request URI earlier. By: Olle Johansson (oej) 2007-03-13 04:12:08 Committed to 1.4, rev 58843. Thanks! | ||