| Summary: | ASTERISK-08978: [patch] Support for Cisco 7935 | ||
| Reporter: | slimey (slimey) | Labels: | |
| Date Opened: | 2007-03-09 08:45:50.000-0600 | Date Closed: | 2007-07-18 14:48:49 |
| Priority: | Major | Regression? | No |
| Status: | Closed/Complete | Components: | Channels/chan_skinny |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) asterisk-trunk-7935.patch | |
| Description: | Please find attached a patch which makes chan_skinny work with the Cisco 7935. This will need testing against some other phone types, as I've had to change the NewCall softkey handler, and also added NewCall back into the softkey set for the OnHook state. | ||
| Comments: | By: dea (dea) 2007-06-05 16:54:53 The enbloc message handling looks good and is likely needed for new phones. The NewCall softkey changes have already been made in trunk (a little differently, but accomplish the same goal) I like the change to the default softkey template to add the NewCall button, but others may not.... It might be worthwhile to split the patch up into the three features so that they can be considered individually. By: Jason Parker (jparker) 2007-06-05 17:07:48 Since we'll have enbloc dialing, I think the newcall softkey should be there in the onhook state. Also, would I be correct in saying that the second to last chunk wouldn't be needed anymore, with the recent fixes that were put in? By: dea (dea) 2007-06-05 18:19:59 Correct, the second to last chuck was implimented in the vm/speeddial patch. I'm not familiar with the term enbloc and google is providing too much info and not enough. The new call button has many handy uses, but my favorite (which the code already handles with out the enbloc feature) is that I always leave my headset enabled. If I press answer to a new call audio goes to the headset. If I press NewCall, audio goes to the headset. It is a trivially little thing, but I miss it oh so much when using chan_skinny By: sbisker (sbisker) 2007-07-13 08:24:03 Any chance of getting this into 1.4, so I can get my 7921G phones to work? By: Digium Subversion (svnbot) 2007-07-18 14:48:49 Repository: asterisk Revision: 75714 ------------------------------------------------------------------------ r75714 | qwell | 2007-07-18 14:48:48 -0500 (Wed, 18 Jul 2007) | 13 lines Merged revisions 75711 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 (closes issue ASTERISK-8978) ........ r75711 | qwell | 2007-07-18 14:54:32 -0500 (Wed, 18 Jul 2007) | 4 lines Fixes for 7935/7936 conference phones. Issue 9245, patch by slimey. ........ ------------------------------------------------------------------------ | ||