Summary:	ASTERISK-08921: [patch] answeronpolarityswith is not working after a reload
Reporter:	Guillermo Salas M. (razametal)	Labels:
Date Opened:	2007-03-01 22:53:25.000-0600	Date Closed:	2007-07-09 15:04:33
Priority:	Minor	Regression?	No
Status:	Closed/Complete	Components:	Channels/chan_zap
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) chanzap_polarityreload_12.diff ( 1) chanzap_polarityreload.diff ( 2) zapata.conf-20070228-01
Description:	Using asterisk 1.2.15 and zaptel 1.2.5 and one TDM02B. The polarity detection is working but if I execute reload from CLI the polarity detection does not work. I need execute restart now from CLI to have the polarity working again.
Comments:	By: Guillermo Salas M. (razametal) 2007-03-02 08:26:44.000-0600 Looking the log file when a reload is issued: Mar  2 09:25:27 WARNING[10802] chan_zap.c: Ignoring signalling Mar  2 09:25:27 WARNING[10802] chan_zap.c: Ignoring answeronpolarityswitch Mar  2 09:25:27 WARNING[10802] chan_zap.c: Ignoring hanguponpolarityswitch Mar  2 09:25:27 WARNING[10802] chan_zap.c: Ignoring signalling Mar  2 09:25:27 WARNING[10802] chan_zap.c: Ignoring signalling Mar  2 09:25:27 WARNING[10802] chan_zap.c: Ignoring answeronpolarityswitch Mar  2 09:25:27 WARNING[10802] chan_zap.c: Ignoring hanguponpolarityswitch By: Tzafrir Cohen (tzafrir) 2007-03-02 08:56:15.000-0600 The processing of zapata.conf has changed in 1.2.15 (and should have resolved exactly those problems, strange). Please try adding an explicit answeronpolarityswitch=no in the beginning of the channels section  and see if it changes anything. By: Guillermo Salas M. (razametal) 2007-03-02 09:11:26.000-0600 Added answeronpolarityswitch=no at the begining of channels section, this is the log when use reload: Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring answeronpolarityswitch Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring signalling Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring answeronpolarityswitch Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring hanguponpolarityswitch Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring signalling Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring signalling Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring answeronpolarityswitch Mar  2 10:09:11 WARNING[11525] chan_zap.c: Ignoring hanguponpolarityswitch Does not change anything. By: Serge Vecher (serge-v) 2007-03-02 09:56:26.000-0600 are you actually using Zaptel 1.2.5? The latest is 1.2.14 ... By: Tzafrir Cohen (tzafrir) 2007-03-02 10:25:19.000-0600 Should "answeronpolarityswitch" be respected on a reload as well? It seems that it it was previously set in a reload to the last value from zapata.conf. Now it is set on reload to the default value. I'm adding a patch vs. current 1.2 branch that should hopefully fix it for those two variables. Very much untested. By: Guillermo Salas M. (razametal) 2007-03-02 17:30:30.000-0600 [quote]are you actually using Zaptel 1.2.5? The latest is 1.2.14 ...[/quote] Sorry, is zaptel 1.2.14 By: Guillermo Salas M. (razametal) 2007-03-02 17:42:26.000-0600 [quote]I'm adding a patch vs. current 1.2 branch that should hopefully fix it for those two variables. Very much untested.[/quote] Yes.. the patch works. Thank you very much. By: Tzafrir Cohen (tzafrir) 2007-06-13 12:25:15 A disclaimed patch for Asterisk 1.2 with basically the same changes. I moved all the variables I thought I could safely touch. I don't know exactly what are the globals defaultcic and defaultozz. By: Digium Subversion (svnbot) 2007-07-09 15:04:32 Repository: asterisk Revision: 74160 ------------------------------------------------------------------------ r74160 | qwell | 2007-07-09 15:04:31 -0500 (Mon, 09 Jul 2007) | 25 lines Merged revisions 74159 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.4 Closes issue ASTERISK-8921 ................ r74159 | qwell | 2007-07-09 15:19:28 -0500 (Mon, 09 Jul 2007) | 16 lines Merged revisions 74158 via svnmerge from https://origsvn.digium.com/svn/asterisk/branches/1.2 ........ r74158 | qwell | 2007-07-09 15:18:15 -0500 (Mon, 09 Jul 2007) | 8 lines Several chan_zap options were not working on reload because they were arbitrarily disallowed when reloading some/most PRI options (such as signalling) was disallowed. Options such as polarityonanswerdelay and answeronpolarityswitch can safely be changed on a reload. This corrects that behavior. Issue 9186, patch by tzafrir. ........ ................ ------------------------------------------------------------------------