| Summary: | ASTERISK-08862: properly include lock.h in utils.c | ||
| Reporter: | Martin Vit (festr) | Labels: | |
| Date Opened: | 2007-02-22 13:48:41.000-0600 | Date Closed: | 2007-06-30 09:20:06 |
| Priority: | Minor | Regression? | No |
| Status: | Closed/Complete | Components: | Core/General |
| Versions: | Frequency of Occurrence | ||
| Related Issues: | |||
| Environment: | Attachments: | ( 0) error ( 1) utils.h.patch | |
| Description: | Last commit r55750 adds to lock.h inline macros and in utils.c before "#include lock.h" should be defined AST_API_MODULE. This brakes my private svn branch. | ||
| Comments: | By: Tilghman Lesher (tilghman) 2007-02-25 09:22:02.000-0600 Could you provide more information? I'm not sure how this breaks anything. By: Martin Vit (festr) 2007-02-25 09:32:15.000-0600 it brakes compilation in my private asterisk 1.2 branch which is patched 1.2 with jitterbuffer patches. I dont know why, but if you look at utils.c there is define AST_API_MOUDULE before every included files which use inlines. so i define AST_API_MODULE before #include "asterisk/lock.h" too and it works. Vanilla asterisk.1.2 compiles fine without this define. (#define AST_API_MODULE /* ensure that inlinable API functions will be built in this module if required */) By: Tilghman Lesher (tilghman) 2007-02-25 11:01:21.000-0600 By: Russell Bryant (russell) 2007-02-25 18:35:34.000-0600 Fixed, thanks! | ||