[Home]

Summary:ASTERISK-08741: [patch] no callerid on incoming calls
Reporter:Michiel van Baak (mvanbaak)Labels:
Date Opened:2007-02-06 16:01:34.000-0600Date Closed:2007-03-08 13:55:06.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_skinny
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) callerid.patch
( 1) callerid2.patch
( 2) callerid3.patch
( 3) callerid4.patch
( 4) callerid5.patch
( 5) callerid6.patch
( 6) callinfo.patch
( 7) crash_hangup_bt.txt
( 8) incoming-call.txt
Description:Incoming calls to my 7905 and 7960 dont show callerid.
The screen only shows the arrows and a message 'Ring-In' but not the callerid number or name.
They are set because a Verbose will show them on the CLI
Comments:By: Damien Wedhorn (wedhorn) 2007-02-07 13:34:22.000-0600

Does the name and number appear briefly and then is cleared or does it not display at all. Also, can you upload a copy of your log when an inbound call is made (with skinny debug on).
By: Michiel van Baak (mvanbaak) 2007-02-07 14:02:20.000-0600

The name and number do not display at all.
Uploading log now.
By: Damien Wedhorn (wedhorn) 2007-02-07 14:53:43.000-0600

Uploaded a small patch, wont fix the problem but it may help isolate what's going on. Please upload a new log with this patch and skinny debug.
By: Michiel van Baak (mvanbaak) 2007-02-07 15:01:53.000-0600

log is the same cept this one line:

Setting Callinfo: Michiel(064272XXXX) to VanBaak(6000) on office(1)

As you might have guessed I obfuscated the phone numbers and external ip addresses for private sake. They are indeed normal telephone numbers and ip addresses.
By: Damien Wedhorn (wedhorn) 2007-02-07 15:11:41.000-0600

It looks like the data is being sent which tends to imply it's a skinny protocol issue. I don't have time at the moment, but will see if I can have a look at this later on.

I don't have any 79xx phones, can anyone get a trace with ccm and see what is meant to be sent. I don't know, but different firmware versions may impact on what should be sent as well.
By: Michiel van Baak (mvanbaak) 2007-02-08 12:20:58.000-0600

Some info about the phones (issue is with both my 7960 and 7905)
7960:
Cisco Systems, Inc. IP Phone CP-7960G ( SEP0015626A4B99 )
App Load ID P00308000300
Boot Load ID PC0303010200
Version 8.0(3.0)
DSP 4.0(1.0)[A0]
Expansion Module 1
Expansion Module 2
Hardware Revision 4.5
Serial Number INM0935251M
Model Number CP-7960G
Codec ADLCodec
Amps 5V Amp
C3PO Revision 2
Message Waiting NO

7905:
Cisco IP Phone 7905
App Load ID CP7905080001SCCP051117A
Boot Load ID LD0100BOOT021112A
Software Version 8.0.1(051117A)
Hardware Revision 0x0005 0x0000
Serial Number INM08481SMJ
Product ID CP-7905G
H/W Features 0x00000002
BTXML Cards Version LD04-25-2002#0
Message Waiting NO
By: Damien Wedhorn (wedhorn) 2007-02-09 15:47:27.000-0600

Added callerid.patch. The callinfo structure has been changed based on the structure in chan_sccp. Not tested as I don't have any phones to test this feature with, but compiles and I still have normal functionality on my 30VIP's and SP12's.
By: Jason Parker (jparker) 2007-02-09 18:51:25.000-0600

wedhorn, do you have a disclaimer on file with Digium already?
By: Damien Wedhorn (wedhorn) 2007-02-09 19:06:30.000-0600

Should do, I faxed it off a couple of months ago.
By: Jason Parker (jparker) 2007-02-09 19:16:00.000-0600

I just re-read your comment, and if this is based off of info from chan_sccp in any way, we cannot and will not use it.

If you can provide an alternative source of information (such as a CCM pcap dump), then we can use it.

Having said that, I *do* have a patch which implements much of this, which I dug out of a pcap dump from CCM, so I know that it's there.
By: Damien Wedhorn (wedhorn) 2007-02-09 20:31:51.000-0600

Uploaded new patch (callerid2.patch). Structure is now based on ethereal (naming is a mix of skinny and ethereal, off the point, but it may be a good idea for common naming between skinny and ethereal).

However, lineInstance and callInstance (called instance in skinny) have been swapped as per chan_sccp. Needs testing and if it works we should probably pass on to ethereal.

Any chance and someone sending me some dumps.
By: Michiel van Baak (mvanbaak) 2007-02-10 03:37:14.000-0600

tried callerid2.patch but still no callerid on my phones.
It compiles and loads fine and no warnings or errors when making calls.
By: Damien Wedhorn (wedhorn) 2007-02-12 02:15:25.000-0600

Added two more patches. Could you please try patches 3 and 4.

Does anybody have a tcp dump of a CCM to 79xx? Please? This is really hard when I have no idea what we are actually meant to send.
By: Michiel van Baak (mvanbaak) 2007-02-12 11:16:34.000-0600

callerid3.patch does not compile:
  [CC] chan_skinny.c -> chan_skinny.o
chan_skinny.c:335: error: expected ?:?, ?,?, ?;?, ?}? or ?__attribute__? before ?PIRestrictionBits?
make[1]: *** [chan_skinny.o] Error 1
make: *** [channels] Error 2

same with callerid4.patch:
  [CC] chan_skinny.c -> chan_skinny.o
chan_skinny.c:335: error: expected ?:?, ?,?, ?;?, ?}? or ?__attribute__? before ?PIRestrictionBits?
make[1]: *** [chan_skinny.o] Error 1
make: *** [channels] Error 2
By: Serge Vecher (serge-v) 2007-02-12 11:21:34.000-0600

wedhorn, just to help you out with some advice here: not that many people check the bug-tracker; the asterisk-dev mailing list has much more exposure for the kind of request you have.
By: Damien Wedhorn (wedhorn) 2007-02-12 14:01:10.000-0600

There's a typo in callerid3 and callerid4, after patching, remove the space between party and PIRestrictionBits on line 335.
By: Michiel van Baak (mvanbaak) 2007-02-12 14:13:01.000-0600

Hate to say it.
Both patches dont change anything.
Displays dont show callerid information.
By: Damien Wedhorn (wedhorn) 2007-02-14 14:04:54.000-0600

Another patch (callerid5). After looking at some tcp dumps it looks like we need to send the callerid as a text message. This is only a test patch in that hopefully it will display something, but it wont clear it. There are a couple of what look like control characters (\200 and \027) and I wouldn't have a clue what they do.

If you get anything different displayed, please try to describe what you get as fully as possible.
By: Michiel van Baak (mvanbaak) 2007-02-14 15:48:52.000-0600

I'll test tomorrow.
Will let you know what happens.
By: Michiel van Baak (mvanbaak) 2007-02-15 12:27:53.000-0600

On my 7960 it shows:
From: <number>

But it's only a message on the place where it tells me how many missed calls etc.
The grey block where the callerid info is supposed to be shown remains empty and the missed calls list still shows: External call/unknown number

I can see the number while the phone is ringing, so that's nice but I dont think this is how it's supposed to be.
By: Michiel van Baak (mvanbaak) 2007-02-15 12:30:05.000-0600

same goes for my 7905.
the skinny debug line shows:
Setting Callinfo to Michiel gsm(0642724454) from Livingroom(6002) on livingroom(1)

So it only shows the number in the what I call 'notification area' and not the name.
By: pj (pj) 2007-02-15 13:13:36.000-0600

FYI: incomming callerid name and number is working fine on my ci$co 7920, even without any extra skinny patch applied.
Asterisk SVN-trunk-r53885
By: Damien Wedhorn (wedhorn) 2007-02-16 15:33:55.000-0600

And another one (callerid6.patch). Three main changes, set callInstance in call_info (seems to be the instance of that call on the line - set to 1, so probably no good for call waiting and the like), add display_pri_notify message (not that I think it has much to do with this bug), and finally (reordered the transmission of packets to be the same as a CCM dump).

The packets now sent to the phone appear to be the same, and in the same order, as a dump I have of a CCM call to a 7960. The only difference is that chan_skinny seems to combine some of the packets, but it does appear that the devices can handle this (at least the 30VIP).
By: Michiel van Baak (mvanbaak) 2007-02-17 04:13:57.000-0600

It's working!
Thanks a lot for all the work wedhorn.
By: Damien Wedhorn (wedhorn) 2007-02-17 04:53:27.000-0600

No probs, but I am guessing that there is still a bit to do yet. First, so I can understand a bit more, can you tell me what is displayed where. Also, there appears to be a message that is displayed for 10 seconds, can you tell where and what this message is.

How does the display work when other things happen like answering, hangup, timeout without answering etc.
By: Michiel van Baak (mvanbaak) 2007-02-17 05:03:47.000-0600

Ok, let me find my digital photocamera.
I'll make pictures of my 7960 while performing several actions.
Is it ok if I post external links here or do you want me to zip and attach everything ?
By: Michiel van Baak (mvanbaak) 2007-02-17 05:26:34.000-0600

Hhmm
With callerid6.patch applied asterisk dies when I hangup a call.
Attached crash_hangup_bt.txt with a bt full.
By: Michiel van Baak (mvanbaak) 2007-02-17 05:36:32.000-0600

I took some pictures of the phone display while calling myself.
I added comments to them so you know what is going on.
Look at them here: http://images.vanbaak.info/thumbnails.php?album=34
By: Damien Wedhorn (wedhorn) 2007-02-17 06:01:01.000-0600

Had a look at the backtrace and it appears that the asterisk dial application is dying. Does it happen with every hang up? Can you provide your asterisk log with skinny debug on.

Also, can't find your comment about the photos.
By: Michiel van Baak (mvanbaak) 2007-02-17 06:53:13.000-0600

ugh, I hate coppermine.
I provided names and comments in iPhoto and exported it.
Added names and description now. Excuses.
By: Michiel van Baak (mvanbaak) 2007-02-17 06:55:09.000-0600

The crash happens on every hangup.
I only tested it with chan_skinny, because I only have those phones.
I'm downloading x-lite for my ibook now so I can test if it happens on sip as well.

I'll let it die and generate a log for you in about 10 minutes.
By: Michiel van Baak (mvanbaak) 2007-02-17 07:07:14.000-0600

I dont think the crash is because of chan_skinny.
Asterisk is also dying when I remove the skinny devices from my Dial line and only put my xlite in there.
I upgraded my asterisk before patching callerid6 into chan_skinny

This is not helping at all.
By: Michiel van Baak (mvanbaak) 2007-02-17 07:10:24.000-0600

svn up -r 53778 is now running.
Will recompile from scratch with callerid6.patch applied.

Give me 30 minutes and I can tell you more.
By: Damien Wedhorn (wedhorn) 2007-02-17 07:18:11.000-0600

Yeah, I think it is a problem elsewhere in asterisk. I was using 53750 and it works fine with a 30VIP. Upgraded to the latest and couldn't even get a call without a crash.
By: Michiel van Baak (mvanbaak) 2007-02-17 07:21:25.000-0600

sorry for all the noise ;)

I reverted to the same version as you are (looked at the rev number in your patch)
Asterisk stays alive now, no matter what I do.
Looks like some other commits borked asterisk bigtime. CALLERID vars empty, crashes etc.

Roundup:
callerid6.patch fixes the callerid issues I reported in this bug.
The images on my website are still valid.
No crashes.

Thanks a lot, I'm a happy * user again.
By: Damien Wedhorn (wedhorn) 2007-02-17 07:28:42.000-0600

What revision where you using for the backtrace you posted?
By: Michiel van Baak (mvanbaak) 2007-02-17 07:31:47.000-0600

55155 I think.
I did not do a 'make clean'
I did:
svn up
./configure
patch -p0 < callerid6.patch
make
make install
asterisk -r
cli>restart now

After a complete clean install
make uninstall
make clean
make distclean
svn up
./configure
patch -p0 < callerid6.patch
make
make install

asterisk died earlier. It will die when my phone is ringing. without the make uninstall it died after hangup.

I'm back at Asterisk SVN-trunk-r53750 built by root @ Ifrid on a i686 running Linux on 2007-02-17 13:07:32 UTC
and everything is fine now.


By: Damien Wedhorn (wedhorn) 2007-02-17 07:56:01.000-0600

I just tried 55155 again and it seems to be working with a full clean install.
By: Michiel van Baak (mvanbaak) 2007-02-17 07:58:02.000-0600

gonna try that as well then :)
will report back soon.
By: Michiel van Baak (mvanbaak) 2007-02-17 08:11:42.000-0600

started from scratch including the 'make uninstall-all'
Everything seems to work with the skinny devices. Did not try my xlite yet but I trust that works as well.
Thanks for your patience ;)

qwell, can you apply callerid6 in trunk if wedhorn agrees. It fixed callerid issues here :)
By: Jason Parker (jparker) 2007-02-17 11:11:16.000-0600

Fixed in 1.4 and trunk in revisions 55217 and 55218.

I used a different patch, without all of the "extra" stuff.  Committed patch was confirmed to work by mvanbaak.
By: Dwayne Hubbard (dhubbard) 2007-03-08 13:55:06.000-0600

verified disclaimer