Summary:	ASTERISK-08740: [patch] Configurable voicemail option prompts
Reporter:	James Rothenberger (jaroth)	Labels:
Date Opened:	2007-02-06 15:06:28.000-0600	Date Closed:	2011-06-07 14:02:45
Priority:	Major	Regression?	No
Status:	Closed/Complete	Components:	Applications/NewFeature
Versions:		Frequency of Occurrence
Related Issues:
Environment:		Attachments:	( 0) voicemail_prompts_v2.patch ( 1) voicemail_prompts_v3.patch
Description:	Provide the ability to configure the option prompts in the voicemail system.  Large voicemail migration projects may warrant that the "new" system prompts mimic the "old" system prompts. For instance, "Press 4 for the previous message" could be "Press 3 for the previous message".  This change would require both a new prompt recording "vm-prev.gsm" and a change to the case statement in the code.   These options could be configuration file driven, using something like: vm-prev-sound="my-vm-prev.gsm" vm-prev-option=3 The defaults would not need to be specified and would be set to the current options. ****** ADDITIONAL INFORMATION ****** We are considering this change in the voicemail code and are looking for input into any current work in this area, or suggestions/alternatives for implementation.
Comments:	By: Leif Madsen (lmadsen) 2007-02-06 16:25:04.000-0600 FYI: First thing to note is that since this would be a "feature", you must build it against trunk, and not 1.4.x. By: James Rothenberger (jaroth) 2007-02-07 14:20:56.000-0600 Understood.  Can this be changed in the Issue Details so it is correctly reflected? By: James Rothenberger (jaroth) 2007-02-07 14:22:10.000-0600 Assuming there are no objections or comments, I am planning on adding this feature shortly. By: Leif Madsen (lmadsen) 2007-02-07 14:47:45.000-0600 jaroth: No objections -- just need to see the code for new features. Also, be sure to file a disclaimer and indicate as such before posting code to the bug tracker. Thanks! By: C F (shmaltz) 2007-02-08 12:14:22.000-0600 Some ideas: * Allow for more than one sound file to be set as the options, so that someone could add vm-option1&press1 for one option combined from 2 sound files * Allow templates, so that one could allow a user to chose how their options should look from within the dialplan, and I guess this could be acomplished thru an arg to app_voicemail. Or at the very least these options should be configurable in voicemail.conf on a per mailbox basis. * Add the ability of an additional option that just executes an app. The idea is that one could jump out of VM and just dial using app_disa, very usefull. Or record prompts. * This one has nothing to do with this feature but in general with app_voicemail, at the moment there is no way to access just certain functions from app_voicemail except for the authentication thru app_vmauthenticate. There are ohter functions that could be usefull as well, including, change password, play recorded name. By: Tilghman Lesher (tilghman) 2007-02-08 12:32:30.000-0600 Also, there should be no need to specify ".gsm" in the configuration file.  The sound routines are built to consider the path of least cost when translating a sound file to the codec needed. By: James Rothenberger (jaroth) 2007-03-01 12:03:14.000-0600 There would currently need to be about 36 additional lines in voicemail.conf to support this feature.  Would it be acceptable to put this (optional) information in a separate config file (voicemail_opts.conf)? By: Anthony LaMantia-2 (anthonyl) 2007-03-05 15:25:27.000-0600 Is there a file/patch/branch related to this issue? By: James Rothenberger (jaroth) 2007-03-05 15:27:12.000-0600 There will be in a day or two.  I am currently testing... By: James Rothenberger (jaroth) 2007-03-06 13:23:41.000-0600 New patch uploaded.   OPTIONAL voicemail.conf settings: main-sound=vm-opts  ; main menu recording main-options-key=0 main-listen-key=1 main-listen-sound=vm-messages main-folder-key=2 main-folder-sound=vm-changeto main-advanced-key=3 main-advanced-sound=vm-advopts listen-previous-key=4 listen-previous-sound=vm-prev listen-replay-key=5 listen-replay-sound=vm-repeat listen-next-key=6 listen-next-sound=vm-next listen-delete-key=7 listen-delete-sound=vm-delete listen-undelete-sound=vm-undelete listen-forward-key=8 listen-forward-sound=vm-toforward listen-save-key=9 listen-save-sound=vm-savemessage advanced-reply-key=1 advanced-reply-sound=vm-toreply advanced-callback-key=2 advanced-callback-sound=vm-tocallback advanced-envelope-key=3 advanced-envelope-sound=vm-tohearenv advanced-newcall-key=4 advanced-newcall-sound=vm-tomakecall advanced-message-key=5 advanced-message-sound=vm-leavemsg options-sound=vm-options ; main options recording options-unavail-key=1 options-unavail-sound=vm-rec-unv options-busy-key=2 options-busy-sound=vm-rec-busy options-name-key=3 options-name-sound=vm-rec-name options-temp-key=4 options-temp-sound=vm-rec-temp options-password-key=5 By: Serge Vecher (serge-v) 2007-03-06 13:55:12.000-0600 Good work, jaroth. A couple of comments -> 1. Could you please clarify the disclaimer status? 2. Take out the bit of code that belongs to 9046. By: James Rothenberger (jaroth) 2007-03-06 14:08:57.000-0600 Disclaimer should be on file, looks for disclaimer done for University of Pennsylvania. By: Russell Bryant (russell) 2007-03-06 17:05:32.000-0600 One thing missing here is the update to voicemail.conf.sample to describe all of the new options. By: James Rothenberger (jaroth) 2007-03-08 14:02:34.000-0600 Version 3 of patch has additions to voicemail.conf.sample. By: Aujang Abadi (spectheintro) 2007-04-05 08:33:28 Does this patch enable you to disable portions of the voicemail? For example, can you remove "change folders" from the main prompt? This would be an excellent feature to add, if at all possible. By: James Rothenberger (jaroth) 2007-04-05 08:36:23 This patch does not include that functionality, although I agree that it would be useful. By: Aujang Abadi (spectheintro) 2007-04-05 08:40:11 jaroth, is there any way I can get in touch with you? I have tried to find some sort of "contact user" button but I have been unsuccessful. By: James Rothenberger (jaroth) 2007-04-05 08:47:16 I'd rather not post email addresses here, but check out imapstorage.txt in the docs directory of any 1.4 version. By: Jason Parker (jparker) 2007-04-06 11:22:21 A couple questions... Is there any reason you changed it from switch statements to multiple if/else if statements? You probably want to use ast_copy_string instead of strcpy. Also, this isn't a big deal, but I noticed that you initialize the *_key variables several times.  You hard-code them in one place, then in another place, you set them to the DEFAULT_*_KEY #define's By: Jason Parker (jparker) 2007-04-06 11:23:45 oh, and there is an extra ; in the sample config - might want to include that in your next patch By: Tilghman Lesher (tilghman) 2007-09-12 13:18:36 Patch no longer applies cleanly, and we haven't heard back with an updated patch, either. By: James Rothenberger (jaroth) 2007-09-13 08:30:55 My apologies.   I will resubmit a patch that applies cleanly. I expect that work on this patch is a few weeks out. By: Digium Subversion (svnbot) 2007-11-26 12:24:04.000-0600 Repository: asterisk Revision: 89605 U   team/group/upenn/apps/app_voicemail.c U   team/group/upenn/configs/voicemail.conf.sample ------------------------------------------------------------------------ r89605 | russell | 2007-11-26 12:24:03 -0600 (Mon, 26 Nov 2007) | 2 lines add configurable prompt support from issue ASTERISK-8740 ------------------------------------------------------------------------ By: Criss Keating (crissk) 2007-12-03 14:13:18.000-0600 Should the status here be updated to closed? Thanks! By: Tilghman Lesher (tilghman) 2007-12-03 16:36:17.000-0600 I'm concerned that allowing people to change the number option is a drastic enough change that people will expect that if they change the option that the prompts will automatically change with it.  I'd like to hear about alternative approaches that ensure that changing the number options is not enabled by default, so as to avoid this problem as best as possible.  Possibly, this could be enabled in 'make menuselect', with a warning that the prompts will not change automatically if you enable that option. Or another option would force the original behavior if the prompt is not changed from the default (with a warning on startup). By: Michiel van Baak (mvanbaak) 2008-01-12 18:21:08.000-0600 is all this still relevant now we have the minivm functions ? As far is I know this allows you to create your own vm ivr. By: Leif Madsen (lmadsen) 2008-01-13 04:57:46.000-0600 I still don't think minivm is a replacement for regular voicemail, so I'm pretty sure this still still relevant By: Nir Simionovich (GreenfieldTech - Israel) (greenfieldtech) 2008-01-13 12:27:13.000-0600 interesting patch - if you need help, contact me I'm willing to assist. nirs@greenfieldtech.net By: Criss Keating (crissk) 2008-01-18 11:40:43.000-0600 Corydon76 how do we move forward with this patch? By: Tilghman Lesher (tilghman) 2008-04-02 13:30:40 crissk:  I'm not convinced that we SHOULD move forward on this patch.  The problem is that anybody making such a change is going to need to also alter the source code to voicemail, as changing the prompts won't change the behavior. Once you get into altering source code, there is no advantage to this patch, as you could do the same thing (changing the prompts) within the source code itself. Unless you can convince me (or another developer) otherwise, I don't think this patch is going to go in. By: James Rothenberger (jaroth) 2008-04-03 08:08:09 Maybe the functionality is not clear here...   The idea is to allow the NUMBERS and RECORDINGS to be changed for the different existing options - it does not change underlying functionality.  These can be changed in the configuration file, no need for code changes.  The playback files would only be changed to re-order the prompts or make an option clearer, or "match" a previous voicemail system's prompts.  This patch is NOT meant to allow the user to somehow change the functionality of voicemail - only to be able to configure voicemail to "feel" more like another system that a user may be accustomed to (when migrating TO asterisk). By: Tilghman Lesher (tilghman) 2008-04-03 09:01:13 There may be a problem that you have not taken into account.  We record all of our prompts in 3 standard languages, English, Spanish, and French, and even among these very few languages, there are considerable language differences that warrant completely different ordering.  This makes implementing this patch to our standards (of accommodating all 3 languages) far more difficult than how this patch currently stands and represents a huge amount of work still to do. If you'd like to obtain the translations on your own (subject to review by our native language speakers) and ensure that the prompts accommodate the language differences, that would address these concerns.  Please note that you do NOT need to obtain the prompts, as we have the prompts recorded specially, at a higher bitrate, for compression to the various formats.  The only thing that needs to be done is to obtain the translations and ensure that the piecing together of the various phrases makes sense to a native speaker of each language. By: James Rothenberger (jaroth) 2008-04-03 09:08:42 You are correct, I didn't consider that! By: James Rothenberger (jaroth) 2008-04-04 10:14:12 We're fine with letting this patch go, we can revisit it in the future if necessary. By: Tilghman Lesher (tilghman) 2008-04-04 10:41:09 Suspending for now, as agreed.