Summary: | ASTERISK-08730: Zaptel is not compiling, something related to xbus-core.c - xbus-core.o | ||
Reporter: | Ruy Rocha (ruyrocha) | Labels: | |
Date Opened: | 2007-02-04 16:29:19.000-0600 | Date Closed: | 2008-06-07 12:37:36 |
Priority: | Trivial | Regression? | No |
Status: | Closed/Complete | Components: | Core/General |
Versions: | Frequency of Occurrence | ||
Related Issues: | |||
Environment: | Attachments: | ( 0) zaptel-1.2.12_make-linux26_log | |
Description: | Hi, When I try an 'make' or 'make linux26' it breaks on xpp/xbus-core.c: LD [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/wct4xxp.o make[1]: Entering directory `/usr/src/linux-2.6.20' CC [M] /usr/src/asterisk/zaptel-1.2.12/zaptel.o /usr/src/asterisk/zaptel-1.2.12/zaptel.c:188: warning: `fcstab' defined but not used CC [M] /usr/src/asterisk/zaptel-1.2.12/tor2.o CC [M] /usr/src/asterisk/zaptel-1.2.12/torisa.o /usr/src/asterisk/zaptel-1.2.12/torisa.c:1143: warning: `set_tor_base' defined but not used CC [M] /usr/src/asterisk/zaptel-1.2.12/wcusb.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wcfxo.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wctdm.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wctdm24xxp.o CC [M] /usr/src/asterisk/zaptel-1.2.12/ztdynamic.o CC [M] /usr/src/asterisk/zaptel-1.2.12/ztd-eth.o /usr/src/asterisk/zaptel-1.2.12/ztd-eth.c:185: warning: initialization from incompatible pointer type CC [M] /usr/src/asterisk/zaptel-1.2.12/wct1xxp.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wcte11xp.o CC [M] /usr/src/asterisk/zaptel-1.2.12/pciradio.o CC [M] /usr/src/asterisk/zaptel-1.2.12/ztd-loc.o CC [M] /usr/src/asterisk/zaptel-1.2.12/ztdummy.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/base.o HOSTCC /usr/src/asterisk/zaptel-1.2.12/wct4xxp/fw2h /usr/src/asterisk/zaptel-1.2.12/wct4xxp/fw2h /usr/src/asterisk/zaptel-1.2.12/wct4xxp/OCT6114-128D.ima /usr/src/asterisk/zaptel-1.2.12/wct4xxp/vpmoct128_fw.h /usr/src/asterisk/zaptel-1.2.12/wct4xxp/fw2h /usr/src/asterisk/zaptel-1.2.12/wct4xxp/OCT6114-64D.ima /usr/src/asterisk/zaptel-1.2.12/wct4xxp/vpmoct064_fw.h CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/vpm450m.o /usr/src/asterisk/zaptel-1.2.12/wct4xxp/vpm450m.h:33: warning: `oct064_firmware' defined but not used /usr/src/asterisk/zaptel-1.2.12/wct4xxp/vpm450m.h:34: warning: `oct128_firmware' defined but not used CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_adpcm_chan.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_channel.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_chip_open.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_chip_stats.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_conf_bridge.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_debug.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_events.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_interrupts.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_memory.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_miscellaneous.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_mixer.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_phasing_tsst.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_playout_buf.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_remote_debug.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tlv.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tone_detection.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsi_cnct.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/octdeviceapi/oct6100api/oct6100_api/oct6100_tsst.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/apilib/bt/octapi_bt0.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/apilib/largmath/octapi_largmath.o CC [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/../oct612x/apilib/llman/octapi_llman.o LD [M] /usr/src/asterisk/zaptel-1.2.12/wct4xxp/wct4xxp.o CC [M] /usr/src/asterisk/zaptel-1.2.12/xpp/card_fxo.o /usr/src/asterisk/zaptel-1.2.12/xpp/card_fxo.c: In function `__check_report_battery': /usr/src/asterisk/zaptel-1.2.12/xpp/card_fxo.c:38: warning: return from incompatible pointer type CC [M] /usr/src/asterisk/zaptel-1.2.12/xpp/card_fxs.o /usr/src/asterisk/zaptel-1.2.12/xpp/card_fxs.c: In function `__check_poll_digital_inputs': /usr/src/asterisk/zaptel-1.2.12/xpp/card_fxs.c:37: warning: return from incompatible pointer type CC [M] /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.o /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c:88: warning: `kmem_cache_t' is deprecated (declared at include/linux/slab.h:17) /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c:346:83: macro "INIT_WORK" passed 3 arguments, but takes just 2 /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c: In function `xbus_activate': /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c:346: error: `INIT_WORK' undeclared (first use in this function) /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c:346: error: (Each undeclared identifier is reported only once /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c:346: error: for each function it appears in.) /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c: At top level: /usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.c:213: warning: `xbus_poll' defined but not used make[3]: *** [/usr/src/asterisk/zaptel-1.2.12/xpp/xbus-core.o] Error 1 make[2]: *** [/usr/src/asterisk/zaptel-1.2.12/xpp] Error 2 make[1]: *** [_module_/usr/src/asterisk/zaptel-1.2.12] Error 2 make[1]: Leaving directory `/usr/src/linux-2.6.20' make: *** [linux26] Error 2 resurec:/usr/src/asterisk/zaptel-1.2.12# ****** ADDITIONAL INFORMATION ****** I'm using Linux 2.6.20, Debian 3.1 r4. | ||
Comments: | By: Ruy Rocha (ruyrocha) 2007-02-04 18:45:29.000-0600 Hi, After some googling I "patched" ('m not a C coder) and Zaptel compiled. It's a problem (?!) with INIT_WORK. I did the same thing posted here http://www.nabble.com/ics-ib-changes-with-respect-2.6.20-rc1-t2901003.html. xpp/xbus-core.c: (line 346) //INIT_WORK(&xbus->xpds_init_work, (void (*)(void *))xbus_poll, (void *)xbus); INIT_WORK(&xbus->xpds_init_work, xbus_poll); By: Ruy Rocha (ruyrocha) 2007-02-04 19:04:40.000-0600 Sorry, as I can see it's not a Zaptel related issue but a INIT_WORK + Linux 2.6.20* problem. By: Tzafrir Cohen (tzafrir) 2007-02-06 10:18:06.000-0600 Looking into this. By: Kevin P. Fleming (kpfleming) 2007-02-07 13:01:56.000-0600 This is not the correct solution; you've dropped the private data pointer that was being handed to the work_queue worker function, without providing a replacement for it. I'll be taking care of this shortly as we are preparing a new Zaptel release and the same issue affects the wct4xxp and wctc4xxp drivers. By: Joshua C. Colp (jcolp) 2007-02-15 20:14:25.000-0600 Since Kevin has fixed the underlying issue of this I'm closing this report out. All that is left is the evil Redhat issue of 9006. By: Digium Subversion (svnbot) 2008-06-07 12:35:53 Repository: dahdi Revision: 2113 _U branches/1.2/xpp/ U branches/1.2/xpp/Makefile U branches/1.2/xpp/card_fxo.c U branches/1.2/xpp/card_fxs.c U branches/1.2/xpp/card_global.c _U branches/1.2/xpp/init_card_3_24 UU branches/1.2/xpp/init_card_4_24 UU branches/1.2/xpp/init_card_6_24 UU branches/1.2/xpp/init_card_7_24 U branches/1.2/xpp/utils/Makefile U branches/1.2/xpp/utils/genzaptelconf A branches/1.2/xpp/utils/xpp.rules U branches/1.2/xpp/utils/xpp_fxloader A branches/1.2/xpp/utils/zaptel-helper U branches/1.2/xpp/xbus-core.c U branches/1.2/xpp/xdefs.h U branches/1.2/xpp/xpd.h U branches/1.2/xpp/xpp_usb.c U branches/1.2/xpp/xpp_zap.c D branches/1.2/xpp/zaptel-helper ------------------------------------------------------------------------ r2113 | tzafrir | 2008-06-07 12:35:52 -0500 (Sat, 07 Jun 2008) | 12 lines xpp driver rev. 3332: * Reverse polarity and power denial detection. * A short led flash at registration time. * Add a real version of the xpp modules to them (independent of the Zaptel version). * Update our line status even when not registered. * Fixed a false SIG_CHANGED when inserting or removing cable to FXO. * Fixed compilation fixes for 2.6.20 (Bug ASTERISK-8730) * A cleaner fix for the bool changes of 2.6.19 . * Automatically detect echo_can_state_t at debug time. * Automaitcally set XPP_DEBUGFS (depending on debugfs) at compile time. * Bug-fixes to zaptel-helper. ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=2113 By: Digium Subversion (svnbot) 2008-06-07 12:36:14 Repository: dahdi Revision: 2116 _U be/branches/B.2/ U be/branches/B.2/Makefile.kernel26 U be/branches/B.2/wctc4xxp/base.c _U be/branches/B.2/xpp/ U be/branches/B.2/xpp/Makefile U be/branches/B.2/xpp/card_fxo.c U be/branches/B.2/xpp/card_fxs.c U be/branches/B.2/xpp/card_global.c U be/branches/B.2/xpp/firmwares/FPGA_1141.hex U be/branches/B.2/xpp/firmwares/FPGA_1151.hex U be/branches/B.2/xpp/firmwares/FPGA_FXS.hex _U be/branches/B.2/xpp/init_card_3_24 UU be/branches/B.2/xpp/init_card_4_24 UU be/branches/B.2/xpp/init_card_6_24 UU be/branches/B.2/xpp/init_card_7_24 U be/branches/B.2/xpp/utils/Makefile U be/branches/B.2/xpp/utils/genzaptelconf A be/branches/B.2/xpp/utils/xpp.rules U be/branches/B.2/xpp/utils/xpp_fxloader A be/branches/B.2/xpp/utils/zaptel-helper U be/branches/B.2/xpp/xbus-core.c U be/branches/B.2/xpp/xdefs.h U be/branches/B.2/xpp/xpd.h U be/branches/B.2/xpp/xpp_usb.c U be/branches/B.2/xpp/xpp_zap.c D be/branches/B.2/xpp/zaptel-helper U be/branches/B.2/zttranscode.c ------------------------------------------------------------------------ r2116 | qwell | 2008-06-07 12:36:12 -0500 (Sat, 07 Jun 2008) | 45 lines Merged revisions 2102-2104,2110,2113-2114 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.2 ........ r2102 | kpfleming | 2007-02-07 13:52:08 -0600 (Wed, 07 Feb 2007) | 2 lines correct comment ........ r2103 | kpfleming | 2007-02-07 13:52:29 -0600 (Wed, 07 Feb 2007) | 2 lines include headers we need... new kernel releases won't do it for us ........ r2104 | kpfleming | 2007-02-07 13:52:52 -0600 (Wed, 07 Feb 2007) | 2 lines make the workqueue usage compatible with 2.6.20 kernel ........ r2110 | kpfleming | 2007-02-07 14:29:22 -0600 (Wed, 07 Feb 2007) | 3 lines build XPP on the kernels that Xorcom says are OK to build on update workqueue usage to conform to kernel 2.6.20 API ........ r2113 | tzafrir | 2007-02-07 14:58:46 -0600 (Wed, 07 Feb 2007) | 12 lines xpp driver rev. 3332: * Reverse polarity and power denial detection. * A short led flash at registration time. * Add a real version of the xpp modules to them (independent of the Zaptel version). * Update our line status even when not registered. * Fixed a false SIG_CHANGED when inserting or removing cable to FXO. * Fixed compilation fixes for 2.6.20 (Bug ASTERISK-8730) * A cleaner fix for the bool changes of 2.6.19 . * Automatically detect echo_can_state_t at debug time. * Automaitcally set XPP_DEBUGFS (depending on debugfs) at compile time. * Bug-fixes to zaptel-helper. ........ r2114 | tzafrir | 2007-02-07 15:02:17 -0600 (Wed, 07 Feb 2007) | 1 line Update the firmwares from previous commit (2113, Xorcom rev. 3332). ........ ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=2116 By: Digium Subversion (svnbot) 2008-06-07 12:36:36 Repository: dahdi Revision: 2123 _U branches/1.4/xpp/ U branches/1.4/xpp/Makefile U branches/1.4/xpp/README.Astribank U branches/1.4/xpp/card_fxo.c U branches/1.4/xpp/card_fxs.c U branches/1.4/xpp/card_global.c A branches/1.4/xpp/firmwares/FPGA_1141.hex U branches/1.4/xpp/firmwares/FPGA_1151.hex UU branches/1.4/xpp/firmwares/FPGA_FXS.hex A branches/1.4/xpp/firmwares/USB_1140.hex D branches/1.4/xpp/init_card_3_23 A branches/1.4/xpp/init_card_3_24 D branches/1.4/xpp/init_card_4_23 A branches/1.4/xpp/init_card_4_24 A branches/1.4/xpp/init_card_6_24 A branches/1.4/xpp/init_card_7_24 U branches/1.4/xpp/utils/Makefile _U branches/1.4/xpp/utils/adj_clock.8 _U branches/1.4/xpp/utils/adj_clock.c U branches/1.4/xpp/utils/fpga_load.8 U branches/1.4/xpp/utils/fpga_load.c U branches/1.4/xpp/utils/genzaptelconf A branches/1.4/xpp/utils/xpp.rules U branches/1.4/xpp/utils/xpp_fxloader A branches/1.4/xpp/utils/zaptel-helper U branches/1.4/xpp/xbus-core.c U branches/1.4/xpp/xbus-core.h U branches/1.4/xpp/xdefs.h U branches/1.4/xpp/xpd.h A branches/1.4/xpp/xpp_log.h U branches/1.4/xpp/xpp_usb.c U branches/1.4/xpp/xpp_zap.c U branches/1.4/xpp/xpp_zap.h U branches/1.4/xpp/xproto.c U branches/1.4/xpp/xproto.h U branches/1.4/xpp/zap_debug.c U branches/1.4/xpp/zap_debug.h D branches/1.4/xpp/zaptel-helper ------------------------------------------------------------------------ r2123 | tzafrir | 2008-06-07 12:36:34 -0500 (Sat, 07 Jun 2008) | 27 lines Branch 1.4 is back in sync (currently: xorcom rev. 3332): * Performance improvements for multi-XPD (span) devices. * Astribank BRI driver (in next commit). * Changes under /proc: - XBUS and XPD numbers have two digits. - Every script wildcard should be replaced from XBUS-? to XBUS-[0-9]* - Added /proc/xpp/XBUS-*/XPD-*/blink: echo 1 to start and 0 to stop. * Several countries (South Africa, UAE, anybody else) require a shorter ring delay. Adjust FXO reg 0x17 (23)'s bits 0:2 to 011. * Use tasklets to move most of the interrupt PCM copying out of the interrupt. * Debugfs-based code to dump data to userspace (used to debug BRI D channel). * Pretend every 2.6.9 actually has later RHEL's typedefs. * fpga_load supports /dev/bus/usb . * Fixed physical order sorting in genzaptelconf. * Reverse polarity and power denial detection. * A short led flash at registration time. * Add a real version of the xpp modules to them (independent of the Zaptel version). * Update our line status even when not registered. * Fixed a false SIG_CHANGED when inserting or removing cable to FXO. * Fixed compilation fixes for 2.6.20 (Bug ASTERISK-8730) * A cleaner fix for the bool changes of 2.6.19 . * Automatically detect echo_can_state_t at debug time. * Automaitcally set XPP_DEBUGFS (depending on debugfs) at compile time. * Bug-fixes to zaptel-helper. Moved to xpp/utils . * Xbus protocol version: 2.4 (Zaptel 1.2.12/1.4.0 had 2.3). XPS Init scripts renamed accordingly. ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=2123 By: Digium Subversion (svnbot) 2008-06-07 12:37:36 Repository: dahdi Revision: 2144 _U trunk/ _U trunk/xpp/ U trunk/xpp/Makefile U trunk/xpp/README.Astribank U trunk/xpp/card_fxo.c U trunk/xpp/card_fxs.c U trunk/xpp/card_global.c A trunk/xpp/firmwares/FPGA_1141.hex U trunk/xpp/firmwares/FPGA_1151.hex UU trunk/xpp/firmwares/FPGA_FXS.hex A trunk/xpp/firmwares/USB_1140.hex D trunk/xpp/init_card_3_23 A trunk/xpp/init_card_3_24 D trunk/xpp/init_card_4_23 A trunk/xpp/init_card_4_24 A trunk/xpp/init_card_6_24 A trunk/xpp/init_card_7_24 U trunk/xpp/utils/Makefile _U trunk/xpp/utils/adj_clock.8 _U trunk/xpp/utils/adj_clock.c U trunk/xpp/utils/fpga_load.8 U trunk/xpp/utils/fpga_load.c U trunk/xpp/utils/genzaptelconf A trunk/xpp/utils/xpp.rules U trunk/xpp/utils/xpp_fxloader A trunk/xpp/utils/zaptel-helper U trunk/xpp/xbus-core.c U trunk/xpp/xbus-core.h U trunk/xpp/xdefs.h U trunk/xpp/xpd.h A trunk/xpp/xpp_log.h U trunk/xpp/xpp_usb.c U trunk/xpp/xpp_zap.c U trunk/xpp/xpp_zap.h U trunk/xpp/xproto.c U trunk/xpp/xproto.h U trunk/xpp/zap_debug.c U trunk/xpp/zap_debug.h D trunk/xpp/zaptel-helper ------------------------------------------------------------------------ r2144 | tzafrir | 2008-06-07 12:37:35 -0500 (Sat, 07 Jun 2008) | 39 lines Merged revisions 2123-2124 via svnmerge from https://origsvn.digium.com/svn/zaptel/branches/1.4 ........ r2123 | tzafrir | 2007-02-08 02:05:17 +0200 (Thu, 08 Feb 2007) | 27 lines Branch 1.4 is back in sync (currently: xorcom rev. 3332): * Performance improvements for multi-XPD (span) devices. * Astribank BRI driver (in next commit). * Changes under /proc: - XBUS and XPD numbers have two digits. - Every script wildcard should be replaced from XBUS-? to XBUS-[0-9]* - Added /proc/xpp/XBUS-*/XPD-*/blink: echo 1 to start and 0 to stop. * Several countries (South Africa, UAE, anybody else) require a shorter ring delay. Adjust FXO reg 0x17 (23)'s bits 0:2 to 011. * Use tasklets to move most of the interrupt PCM copying out of the interrupt. * Debugfs-based code to dump data to userspace (used to debug BRI D channel). * Pretend every 2.6.9 actually has later RHEL's typedefs. * fpga_load supports /dev/bus/usb . * Fixed physical order sorting in genzaptelconf. * Reverse polarity and power denial detection. * A short led flash at registration time. * Add a real version of the xpp modules to them (independent of the Zaptel version). * Update our line status even when not registered. * Fixed a false SIG_CHANGED when inserting or removing cable to FXO. * Fixed compilation fixes for 2.6.20 (Bug ASTERISK-8730) * A cleaner fix for the bool changes of 2.6.19 . * Automatically detect echo_can_state_t at debug time. * Automaitcally set XPP_DEBUGFS (depending on debugfs) at compile time. * Bug-fixes to zaptel-helper. Moved to xpp/utils . * Xbus protocol version: 2.4 (Zaptel 1.2.12/1.4.0 had 2.3). XPS Init scripts renamed accordingly. ........ r2124 | tzafrir | 2007-02-08 02:30:56 +0200 (Thu, 08 Feb 2007) | 1 line Now 'chans' is used after all. ........ ------------------------------------------------------------------------ http://svn.digium.com/view/dahdi?view=rev&revision=2144 |