|Summary:||ASTERISK-08707: glob as a file name in error message|
|Reporter:||Tzafrir Cohen (tzafrir)||Labels:|
|Date Opened:||2007-02-01 00:08:37.000-0600||Date Closed:||2007-02-02 11:03:24.000-0600|
|Description:||I get the following warning:|
config.c:733 process_text_line: Unknown directive '' at line 3 of manager.d/*.conf
Which turned out to be due to my following stupidity:
$ grep -n '^#' manager.d/*.conf
manager.d/areskicc.conf:3:# are all of those really necessary?
However, I was generally left with the guesswork as to the exact file name.
The message is from main/config.c:process_text_line() that gets the parameter filename from config_text_file_load() . filename is the name of the file as appears in the configuration directive before the glob expantion ("manager.d/*.conf", in this case).
Perhaps we should use fn instead of filename ?
****** ADDITIONAL INFORMATION ******
I'll try to prepare a patch later. The code looks similar in 1.2 and 1.4
As a side note: any point for keeping the AST_GLOB_INCLUDE define?
|Comments:||By: Joshua C. Colp (jcolp) 2007-02-02 11:03:24.000-0600|
Fixed in 1.2 as of revision 53117, 1.4 as of revision 53118, and trunk as of revision 53119. As for AST_INCLUDE_GLOB I can't think of any reason why not but I would suggest asking on asterisk-dev, and it would probably only be done in trunk. Thanks!