[Home]

Summary:ASTERISK-08673: [patch] IMAP Voicemail reports mailbox full if IMAP server does not report quota
Reporter:Emmanuel BUU (neutrino88)Labels:
Date Opened:2007-01-28 11:39:54.000-0600Date Closed:2007-01-29 11:40:42.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Applications/app_voicemail
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:I connnected a mailbox to an IMAP server that did not support (or report) IMAP quota. Upon message deposit, I always get mailbox full prompt.


This comes from the fact that

vms->quota_limit
vms->quota_usage

are not initialized and receive random values


****** ADDITIONAL INFORMATION ******

Index: app_voicemail.c
===================================================================
--- app_voicemail.c     (r?vision 52493)
+++ app_voicemail.c     (copie de travail)
@@ -62,9 +62,9 @@
#include <ctype.h>
#include <signal.h>
#include <pwd.h>
-#include "c-client.h"
-#include "imap4r1.h"
-#include "linkage.h"
+#include "imap/c-client.h"
+#include "imap/imap4r1.h"
+#include "imap/linkage.h"
#endif
#include "asterisk/lock.h"
#include "asterisk/file.h"
@@ -4637,9 +4637,12 @@
       /* debug = T;  user wants protocol telemetry? */
       debug = NIL;  /* NO protocol telemetry? */

+       /* Reset fieds in case server does not report quota */
+       vms->quota_limit = 0;
+       vms->quota_usage = 0;
       if (delimiter == '\0') {                /* did not probe the server yet */
               char *cp;
-#include "linkage.c"
+#include "imap/linkage.c"
               /* Connect to INBOX first to get folders delimiter */
               imap_mailbox_name(tmp, vms, 0, 0);
               stream = mail_open (stream, tmp, debug ? OP_DEBUG : NIL);
Comments:By: Joshua C. Colp (jcolp) 2007-01-29 11:40:42.000-0600

Fixed in 1.4 as of revision 52523 and trunk as of revision 52524. Thanks!