Summary:ASTERISK-08665: [patch][moremanager branch] IAX had no manager command to list peers in proper format
Reporter:j (j)Labels:
Date Opened:2007-01-25 14:00:09.000-0600Date Closed:2007-10-30 09:32:15
Versions:Frequency of
Environment:Attachments:( 0) chan_iax.c.patch
( 1) chan_iax2.c.patch-branch-1.2
( 2) chan_iax2.c.patch-branch-trunk
( 3) chan_iax2.c.patch-branch-trunk-new
Description:The IAX channel driver had no function to list IAX peers in proper manager format. The current output is human readable, but useless for software to use.

I'm submitting a patch that outputs iax peer information in the same format as all other manager commands. I tried to keep the output consistent with the SIPpeers command.

I made the patch against asterisk v1.2.14 release.
It should be trivial to move the patch to 1.4. If you need anything from me please let me know.

Comments:By: Anthony LaMantia-2 (anthonyl) 2007-01-25 15:23:06.000-0600


By: Russell Bryant (russell) 2007-01-25 15:23:32.000-0600

We don't add any new features to release branches.  So, for this to go in, it will have to be against svn trunk.

By: j (j) 2007-01-25 15:38:53.000-0600

That's cool. Any particular branch/revision? Or just grab the trunk?

By: Russell Bryant (russell) 2007-01-25 15:43:54.000-0600

Just the regular trunk.

svn co http://svn.digium.com/svn/asterisk/trunk asterisk-trunk

By: j (j) 2007-01-25 16:28:22.000-0600

Heh. Nevermind. I did it for both of them.

 I was unable to test the trunk branch as I had a compile error in codec_zap.c .

 I forgot to mention as well; I didn't actually replace the functionality of IAXpeers, I created a new function called IAXpeerlist instead so as to not mess anyone up that's already using it.

By: Serge Vecher (serge-v) 2007-02-26 13:25:36.000-0600

codec_zap.c issues in trunk should be fixed, please report test results for trunk

By: j (j) 2007-02-26 14:47:35.000-0600

Tested the patch using today's SVN. Everything went fine except for a simple compile warning (due to my function not defining one of it's args 'const') which I've fixed in the latest patch.

I tested the new function and it worked fine for me.


By: Olle Johansson (oej) 2007-05-15 11:37:16

Will include this in the moremanager branch as a replacement for the current, broken, iaxpeers command. Later on include it in trunk for AMI 1.1 where we change quite a lot.

Thanks for the patch. I wasn't aware of your efforts when I added to CHANGES.moremanager "Someone needs to fix the iaxpeers command"...

By: Olle Johansson (oej) 2007-05-16 14:48:40

ActionID handling was missing, I added that.

By: Olle Johansson (oej) 2007-05-16 14:55:49

Included in branch "moremanager" for testing with other AMI 1.1 changes.

Thanks for contributing to Asterisk! This will move from the "moremanager" branch to svn trunk soon.

By: Brandon Kruse (bkruse) 2007-10-30 09:32:14

Moved to moremanager by oej

Closing :]

(this is awesome!)