[Home]

Summary:ASTERISK-08623: [patch] new channel driver : chan_unistim for Nortel Unistim IP phones
Reporter:c_hans (c_hans)Labels:
Date Opened:2007-01-20 17:15:04.000-0600Date Closed:2007-11-03 08:57:07
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:( 0) chan_unistim.patch
( 1) ustm_no_conf.diff
Description:This is a channel driver for Nortel Unistim (Unified Networks IP Stimulus) protocol. You can use Nortel i2002, i2004 and i2050. Following features are supported : Transfer, Threeway call, Forward, Message Waiting Indication (MWI), Distinctive ring, Call History, Send/Receive CallerID, Redial, (Dynamic) SoftKeys, SendText(), Music On Hold.

http://www.voip-info.org/wiki-Asterisk+UNISTIM+channels

Comments:By: Russell Bryant (russell) 2007-01-20 21:42:18.000-0600

Anyone who has contributed to the development of this channel driver will need to have a disclaimer on file with Digium before we can look at this code.
By: c_hans (c_hans) 2007-01-29 08:52:54.000-0600

disclaimers have been sent by fax to Digium
By: Serge Vecher (serge-v) 2007-02-01 12:00:33.000-0600

c_hans: thanks
By: Dave Bowerman (dbowerman) 2007-02-02 21:14:52.000-0600

tested this with svn trunk 53109.

works fine with a Nortel i2004.
By: Jason Parker (jparker) 2007-04-06 16:22:01

When you say that disclaimers have been sent - do you mean everybody who has ever contributed to the development of this channel driver?

Also, I'm a little disturbed at how little traffic this bug has gotten.  Perhaps it would be a good idea to send an email to the asterisk-dev mailing list to mention that A) it's here, and B) it needs testing.
By: Tzafrir Cohen (tzafrir) 2007-04-08 11:38:43

What exactly is:

 static const struct tone_zone_unistim frequency

This information is already available in both libtonezone and in indications.conf . Can you think of a way to avoid replicating it again?
By: c_hans (c_hans) 2007-04-09 17:48:44

About disclaimers : yes, only me and someone who did the asterisk 1.4 port.

About tone_zone_unistim frequency : it's a list of dial tone frequency. It's used by the internal hardware tone generator of the phone. I use indication.conf for everything else (ring, busy, congestion...).
Using ast_get_indication_zone for the dial tone is possible but requires some additional code in order to support some countries like Italy (a complete setup of the tone generator sequencer). I don't have the time to implement/test that, so I built a list of easy country.
By: Mathieu Rene (math) 2007-05-17 15:58:10

tested with 1.4.4, see the wiki for the latest version with the proper new ast_channel_alloc syntax. Tested with i2002.


By: Clod Patry (junky) 2007-06-05 23:40:08

tested on a production server, works great!

+1 for me to push this in trunk.
By: Clod Patry (junky) 2007-08-31 15:03:23

that will be great if that could be commit to trunk or addons.
deploy my 2nd install with it, still success (with 1.4.11)

Once commited, that will be much easier to maintain.

And this patch prevent segfault, if no config file is present and we try to unload it (for version chan_unistim-1.0.0.5c).


By: Ronald Chan (loloski) 2007-09-07 21:48:52

Any news here please ?, although i have a limited time testing this stuff for a client i can say this works well. i vouch for it on trunk or add-ons :)
By: Digium Subversion (svnbot) 2007-11-01 15:15:39

Repository: asterisk
Revision: 88154

A   team/group/chan_unistim/

------------------------------------------------------------------------
r88154 | russell | 2007-11-01 15:15:38 -0500 (Thu, 01 Nov 2007) | 4 lines

Create a branch for chan_unistim, from issue ASTERISK-8623.  There are multiple positive
test reports.  So, I figure it needs a code review to make sure it meets our
guidelines, and then just merge it in.

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-01 15:26:01

Repository: asterisk
Revision: 88156

A   team/group/chan_unistim/channels/chan_unistim.c
A   team/group/chan_unistim/configs/unistim.conf.sample
A   team/group/chan_unistim/doc/unistim.txt

------------------------------------------------------------------------
r88156 | russell | 2007-11-01 15:26:00 -0500 (Thu, 01 Nov 2007) | 2 lines

Initial import of the code from issue ASTERISK-8623

------------------------------------------------------------------------
By: Digium Subversion (svnbot) 2007-11-02 15:54:25

Repository: asterisk
Revision: 88368

U   trunk/CHANGES
U   trunk/CREDITS
A   trunk/channels/chan_unistim.c
A   trunk/configs/unistim.conf.sample
A   trunk/doc/unistim.txt

------------------------------------------------------------------------
r88368 | russell | 2007-11-02 15:54:24 -0500 (Fri, 02 Nov 2007) | 13 lines

Merge the code from asterisk/team/group/chan_unistim:

This introduces a new channel driver, chan_unistim, that supports the Unistim
VoIP protocol for Nortel phones.  The following models have been confirmed
to work: i2002, i2004 and i2050.

(closes issue ASTERISK-8623)
Reported by: c_hans
Patches:
     chan_unistim.patch uploaded by c (license 304)
     ustm_no_conf.diff uploaded by junky (license 177)
Tested by: c_hans, dbowerman, math, junky, loloski

------------------------------------------------------------------------
By: Clod Patry (junky) 2007-11-02 16:10:41

its looks like it's missing a part of my patch:
-        }
-        return 0;
+         return 0;
+        } else {
+ ast_log(LOG_WARNING, "no conf file\n");
+ return AST_MODULE_LOAD_DECLINE;
+ }


since if there's no config file, and you try to unload it its segfaulting.

By: Russell Bryant (russell) 2007-11-02 16:32:38

Did you test the current version?  I modified that function pretty heavily.
By: Clod Patry (junky) 2007-11-02 16:35:53

ya, i just tested with 88368.

You just have to remove unistim.conf, then restart now, you will see an error with  this config file, then try to module unload chan_unistim.so and boom.

that patch was exactly for this issue.
By: Russell Bryant (russell) 2007-11-02 17:11:45

closing as it doesn't appear to be a problem
By: Digium Subversion (svnbot) 2007-11-03 08:57:07

Repository: asterisk
Revision: 88435

_U  team/group/CDRfix5/
U   team/group/CDRfix5/CHANGES
U   team/group/CDRfix5/CREDITS
U   team/group/CDRfix5/channels/chan_sip.c
A   team/group/CDRfix5/channels/chan_unistim.c
A   team/group/CDRfix5/configs/unistim.conf.sample
A   team/group/CDRfix5/doc/unistim.txt
U   team/group/CDRfix5/main/cli.c
U   team/group/CDRfix5/pbx/pbx_lua.c

------------------------------------------------------------------------
r88435 | murf | 2007-11-03 08:57:06 -0500 (Sat, 03 Nov 2007) | 61 lines

Merged revisions 88367-88368,88370-88371,88376,88408-88409 via svnmerge from
https://origsvn.digium.com/svn/asterisk/trunk

................
r88367 | file | 2007-11-02 14:51:53 -0600 (Fri, 02 Nov 2007) | 12 lines

Merged revisions 88366 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.4

........
r88366 | file | 2007-11-02 17:49:45 -0300 (Fri, 02 Nov 2007) | 4 lines

Make subscribecontext behave as advertised. It will now look for the presence of a hint in the given context (be it subscribecontext or context).
(closes issue ASTERISK-10284)
Reported by: slavon

........

................
r88368 | russell | 2007-11-02 14:56:12 -0600 (Fri, 02 Nov 2007) | 13 lines

Merge the code from asterisk/team/group/chan_unistim:

This introduces a new channel driver, chan_unistim, that supports the Unistim
VoIP protocol for Nortel phones.  The following models have been confirmed
to work: i2002, i2004 and i2050.

(closes issue ASTERISK-8623)
Reported by: c_hans
Patches:
     chan_unistim.patch uploaded by c (license 304)
     ustm_no_conf.diff uploaded by junky (license 177)
Tested by: c_hans, dbowerman, math, junky, loloski

................
r88370 | russell | 2007-11-02 15:25:55 -0600 (Fri, 02 Nov 2007) | 3 lines

Show the channel unique ID in the "show channel concise" output
(closes issue ASTERISK-10674, requested by falves11, patched by me)

................
r88371 | russell | 2007-11-02 15:36:37 -0600 (Fri, 02 Nov 2007) | 2 lines

Don't kill asterisk if extensions.lua is not present.

................
r88376 | russell | 2007-11-02 15:39:36 -0600 (Fri, 02 Nov 2007) | 2 lines

propagate the DECLINE return value back to the loader

................
r88408 | russell | 2007-11-02 16:08:15 -0600 (Fri, 02 Nov 2007) | 2 lines

Convert the CLI commands to the new format

................
r88409 | russell | 2007-11-02 16:36:30 -0600 (Fri, 02 Nov 2007) | 1 line

fix some issues with crashing on unload, when it didn't completely load cleanly
................

------------------------------------------------------------------------