Summary:ASTERISK-08592: Additional checks for option_debug
Reporter:Curt Moore (jcmoore)Labels:
Date Opened:2007-01-16 20:01:58.000-0600Date Closed:2007-01-18 16:57:42.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_debug_diff.txt
( 1) app_voicemail_debug_diff.txt
( 2) chan_sip_debug_diff.txt
( 3) channel_debug_diff.txt
( 4) func_strings_diff.txt
( 5) pbx_debug_diff.txt
Description:Added missing checks for option_debug before writing debug output to the debug logging channel.  This can be seen by setting core debug 0 and configuring the console log channel in logger.conf to display debug messages.  Any debug messages not prefaced by an "if (option_debug)" check will appear in the console.

Changes were made in the following files:


There are likely other instances of this but these are the ones I see most frequently.


I have a disclaimer on file.
Comments:By: Jason Parker (jparker) 2007-01-16 21:08:47.000-0600

Reviewed - will commit tomorrow

By: Curt Moore (jcmoore) 2007-01-17 01:37:12.000-0600

qwell, I found a few more in app_voicemail.  Diff is attached.

By: Clod Patry (junky) 2007-01-17 08:12:22.000-0600

Qwell: if you could wait for my new arch of ast_log before committing that one, that will be appreciated.

By: Curt Moore (jcmoore) 2007-01-17 12:41:45.000-0600

Found some more in main/app.c, diff attached.

I went through some time ago and fixed lots of these, r44253 bug 8076, and the changes were committed to trunk but it appears that they never made it into 1.4.  Not a big deal but seeing the debug messages when debug isn't enabled is just kind of annoying.  Whether or not it's true, I've heard that writing to the debug channel without having debug enabled could cause "bad things" to happen.  Maybe junky's new ast_log stuff will help this.

In any event, since the changes are in trunk, they will make their way in the next major release. :-)

By: Jason Parker (jparker) 2007-01-18 16:57:42.000-0600

Fixed in svn branch 1.4 in revision 51265 and trunk in revision 51266.

Omitted chan_sip.c patch, because I think it's more correct the way it is now.

Much of these changes were already in trunk in one form or another.