|Summary:||ASTERISK-08587: [patch] allow the * as the exit dtmf|
|Reporter:||Clod Patry (junky)||Labels:|
|Date Opened:||2007-01-15 22:20:05.000-0600||Date Closed:||2007-07-03 15:19:12|
|Environment:||Attachments:||( 0) exitkey_fw_58992.diff|
( 1) exitkey_fw_58992-2.diff
( 2) star_exit.diff
|Description:||That patch is the same stuff as option p to exit the meetme conf, but it's for the * dtmf.|
So that option could be combined with regular option p, which will result * or # will exit the conf and pass to the next priority (if any).
|Comments:||By: Jason Parker (jparker) 2007-01-16 11:08:25.000-0600|
Can you also add this to the output of "core show application meetme", and state that it overrides option 's'?
By: Clod Patry (junky) 2007-01-16 11:12:49.000-0600
k, but this is not overide anything, since its S (capital).
By: Jason Parker (jparker) 2007-01-16 11:15:36.000-0600
It does, because you put the CONFFLAG_STAREXIT if check before the CONFFLAG_STARMENU if check. It basically redefines what happens if you press the * key.
edit: Which is fine, we just need to make sure people are aware of that fact
By: Russell Bryant (russell) 2007-02-26 14:47:34.000-0600
Can you just make this an option that takes an argument so that you can specify any key for exiting the conference?
By: Clod Patry (junky) 2007-02-26 14:52:25.000-0600
Sure, i already proposed that idea to qwell.
Will provide a patch for that soon.
Also, I will deprecated the key for exit (option p).
By: Fredrik Wahl (fw) 2007-03-14 09:10:43
Sorry to barge in, but I was about to add this for myself before I found and read this report properly.
I've attached a patch that adds an argument to the 'p' option to let the user set the keys (one or many) to exit the conference. '#' is the default if no arg specified. It will set the variable MEETME_EXIT_KEY to the key pressed.
Faxed in a disclaimer today.
By: Serge Vecher (serge-v) 2007-03-14 09:19:45
fw: thanks for the patch. Curly brackets are not necessary in single line if ... else statements. Also, can you please address qwell's comment on output of "core show application meetme" in note 0057804?
By: Fredrik Wahl (fw) 2007-03-14 09:53:18
Patch updated with information about overriding option 's' if keys contain '*'.
Curly brackets removed
By: Serge Vecher (serge-v) 2007-03-14 10:38:04
cool: what about adding the key to the output of "core show application meetme"?
By: Russell Bryant (russell) 2007-03-14 10:45:07
I do not think it makes sense to add it to the "show application meetme" CLI command. First of all, it could be different for each execution of the meetme application. Second, we don't do anything like that for any other application.
By: Russell Bryant (russell) 2007-03-14 10:46:34
Excuse my last comment. I was thinking of the summary that you would see in "show applications" for some reason. So, I didn't make any sense.
Yes, I agree. It needs to be added to the full documentation of options for the MeetMe application that you see when you run the "core show application meetme" cli command.
By: Fredrik Wahl (fw) 2007-03-19 02:52:59
Did I miss something here?
By: Serge Vecher (serge-v) 2007-03-19 09:29:51
fw: yes, the value of 'exitkeys' needs to be outputed when typing "core show application meetme"
By: Clod Patry (junky) 2007-03-19 09:34:50
serge: it's already there, see option p.
By: Fredrik Wahl (fw) 2007-03-19 09:38:07
Well, doesn't it?
-- allow user to exit the conference by pressing '#' (default)
or any of the defined keys. If keys contain '*' this will override
option 's'. The key used is set to channel variable MEETME_EXIT_KEY.
Or what do you mean by "the value of 'exitkeys'"?
Will exit the conference by pressing 1, 5 or *.
Will exit the conference by pressing # as before.
My patch will allow option 'p' to take the exit keys as an argument and will include the functionality in the original patch star_exit by junky.
By: Jason Parker (jparker) 2007-07-03 15:19:11
Added to svn trunk in revision 73144.