Summary:ASTERISK-08568: [patch] two minor bugfixes for voicemail (one for IMAP storage, one for email notifications)
Reporter:Andrew Kohlsmith (akohlsmith)Labels:
Date Opened:2007-01-12 13:07:05.000-0600Date Closed:2007-01-17 18:51:39.000-0600
Versions:Frequency of
Environment:Attachments:( 0) app_voicemail_gsmcheck.diff
( 1) app_voicemail_minorfixes_take2_8808.diff
( 2) app_voicemail_minorfixes.diff
Description:first fix: build the imap remote directory string properly.  If you do not have any imap flags, and you do not use authuser (such as with Courier-IMAP), the string is built incorrectly: {server:port/imap//user=username}INBOX.

second fix: make_email_file() would test to see if the format was gsm and run base_encode() for the gsm file if so, but the strcmp() test was wrong.  It's a one-liner fix.
Comments:By: Emmanuel BUU (neutrino88) 2007-01-12 13:14:10.000-0600

I made a similar fix (http://bugs.digium.com/view.php?id=8809) but I thought it was related to imapflags settings.

By: Jason Parker (jparker) 2007-01-12 13:19:55.000-0600

Discussed formatting with reporter on IRC.  New patch should be uploaded shortly.

By: Andrew Kohlsmith (akohlsmith) 2007-01-12 13:26:33.000-0600

new patch uses ast_build_string and ast_strlen_zero

By: Andrew Kohlsmith (akohlsmith) 2007-01-12 13:37:05.000-0600

lost the gsm fix... gsmcheck is the fix.

By: Joshua C. Colp (jcolp) 2007-01-17 18:51:39.000-0600

Fixed in 1.4 as of revision 51213 and trunk as of revision 51214. Thanks tzanger!