[Home]

Summary:ASTERISK-08555: Channel h323 has error in code (invalid function using -> ast_append_ha)
Reporter:Alexander Maglyovany (st41ker)Labels:
Date Opened:2007-01-11 08:37:05.000-0600Date Closed:2007-01-22 02:54:41.000-0600
Priority:MajorRegression?No
Status:Closed/CompleteComponents:Channels/chan_h323
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:AS-IS
} else if (!strcasecmp(v->name, "permit") ||
                 !strcasecmp(v->name, "deny")) {
                 user->ha = ast_append_ha(v->name, v->value, user->ha);
            }
     }
     ASTOBJ_UNMARK(user);

***********************************
Proposed MAY-BE

} else if (!strcasecmp(v->name, "permit") ||
                  !strcasecmp(v->name, "deny")) {
                  int err = 0;
                  peer->ha = ast_append_ha(v->name, v->value, peer->ha,&err);
}
}
     ASTOBJ_UNMARK(user);
Comments:By: Alexander Maglyovany (st41ker) 2007-01-11 09:54:55.000-0600

} else if (!strcasecmp(v->name, "permit") ||
                 !strcasecmp(v->name, "deny")) {
                 user->ha = ast_append_ha(v->name, v->value, user->ha);
            }
     }
     ASTOBJ_UNMARK(user);

***********************************
Proposed MAY-BE

} else if (!strcasecmp(v->name, "permit") ||
                 !strcasecmp(v->name, "deny")) {
                 user->ha = ast_append_ha(v->name, v->value, user->ha,NULL);
            }
     }
     ASTOBJ_UNMARK(user);


And sorry again for my mistakes :"(
By: Paul Cadach (pcadach) 2007-01-18 01:06:49.000-0600

Commited. Update to revision 51221 or newer.
By: Paul Cadach (pcadach) 2007-01-22 02:54:41.000-0600

Required changes commited to SVN. If it is not work for you, do not hesitate to re-open the bug.