[Home]

Summary:ASTERISK-08544: Code error in chan_sip.c
Reporter:Alexander Maglyovany (st41ker)Labels:
Date Opened:2007-01-10 11:59:24.000-0600Date Closed:2007-01-10 12:35:22.000-0600
Priority:MinorRegression?No
Status:Closed/CompleteComponents:Core/General
Versions:Frequency of
Occurrence
Related
Issues:
Environment:Attachments:
Description:if (!p->lastinvite && !ast_test_flag(req, SIP_PKT_IGNORE) && !p->owner) {
????????????????/* This is a new invite */
????????????????/* Handle authentication if this is our first invite */
????????????????res = check_user(p, req, SIP_INVITE, e, XMIT_RELIABLE, sin);
????????????????if (res == AUTH_CHALLENGE_SENT)
????????????????????????p->invitestate = INV_COMPLETED;?????????/* Needs to restart in another INVITE transaction */
????????????????????????return 0; <- ????!!!!
????????????????if (res < 0) { /* Something failed in authentication */

***********************

may be it must be something like this:

if (!p->lastinvite && !ast_test_flag(req, SIP_PKT_IGNORE) && !p->owner) {
????????????????/* This is a new invite */
????????????????/* Handle authentication if this is our first invite */
????????????????res = check_user(p, req, SIP_INVITE, e, XMIT_RELIABLE, sin);
????????????????if (res == AUTH_CHALLENGE_SENT) ?{ <-look here
????????????????????????p->invitestate = INV_COMPLETED;?????????/* Needs to restart in another INVITE transaction */
????????????????????????return 0; } <- and here
????????????????if (res < 0) { /* Something failed in authentication */
Comments:By: Alexander Maglyovany (st41ker) 2007-01-10 12:15:39.000-0600

Please excuse me for that "??????"s...
By: Joshua C. Colp (jcolp) 2007-01-10 12:35:21.000-0600

Fixed in 1.4 as of revision 50377 and trunk as of revision 50378. Thanks!