Summary:ASTERISK-08499: [patch] Allow a reason to be specified when pausing an agent.
Reporter:Rene Gollent (rgollent)Labels:
Date Opened:2007-01-05 12:47:14.000-0600Date Closed:2007-09-07 10:55:57
Versions:Frequency of
Environment:Attachments:( 0) app_queue.c.rej
( 1) ast_trunk_app_queue_pause_reason.20070406.patch
( 2) ast_trunk_app_queue_pause_reason.20070906.patch
( 3) ast_trunk_app_queue_pause_reason.20070907.patch
( 4) ast_trunk_app_queue_pause_reason.patch
Description:This patch adds an extra parameter to the manager command/event for QueueMemberPaused. This allows you to specify a reason for the pause, and echoes it in the subsequent manager events. Useful for tracking what your agents are spending time paused on.
Comments:By: Anthony LaMantia (alamantia) 2007-01-05 16:20:21.000-0600

hi rgollent,
can you please upload a svn diff aginst trunk rather then 1.4 as it's feature locked at the moment and we won't be able to add this to it.

By: Rene Gollent (rgollent) 2007-01-05 16:33:08.000-0600


By: Jason Parker (jparker) 2007-04-06 15:46:25

Could you upload a diff against the latest svn trunk?  This patch no longer applies.

Also, your "if (reason)" block doesn't follow coding guidelines.

By: Rene Gollent (rgollent) 2007-04-06 17:01:40

Patch updated, that should fix the style issue as well if I'm not mistaken.

By: Michiel van Baak (mvanbaak) 2007-09-06 14:32:42

Can you provide an up-to-date patch ?
This is what I get when trying this on current trunk:

patching file apps/app_queue.c
Hunk #1 FAILED at 193.
Hunk #2 FAILED at 206.
Hunk #3 FAILED at 217.
Hunk #4 FAILED at 412.
Hunk ASTERISK-1 FAILED at 1892.
Hunk ASTERISK-2 succeeded at 3182 (offset 205 lines).
Hunk ASTERISK-3 succeeded at 3210 with fuzz 2 (offset 207 lines).
Hunk ASTERISK-4 succeeded at 3339 (offset 208 lines).
Hunk ASTERISK-5 FAILED at 3359.
Hunk ASTERISK-6 succeeded at 3374 (offset 189 lines).
Hunk ASTERISK-7 FAILED at 3394.
Hunk ASTERISK-8 succeeded at 4569 (offset 113 lines).
Hunk ASTERISK-9 succeeded at 4584 (offset 113 lines).
7 out of 13 hunks FAILED -- saving rejects to file apps/app_queue.c.rej

.rej file uploaded

By: Rene Gollent (rgollent) 2007-09-06 15:12:46


By: Michiel van Baak (mvanbaak) 2007-09-06 15:36:55

@rgollent: thank you. as soon as your license is approved I'll test and report back :)

By: Michiel van Baak (mvanbaak) 2007-09-07 09:47:20

All works fine on my testsystem.
How about adding some info about reason only being used for logging in the application description when you do 'core show application PauseQueueMember' on the CLI ?

Thank you for the update.

By: Rene Gollent (rgollent) 2007-09-07 09:59:35

I actually had that in the original patch, some of the rejects were because the help text in the more recent versions of trunk has been significantly abridged (i.e. options is no longer documented) so I wondered if there was some different convention to this now. Want me to just add it?

By: Rene Gollent (rgollent) 2007-09-07 10:07:34

Also note it's not just being used for logging, the pause reason's also reported in the QueueMemberPaused manager event if given, so it's pertinent to anyone using the manager for live queue monitoring as well.

By: Michiel van Baak (mvanbaak) 2007-09-07 10:07:47

The information lines in your original patch look fine to me.
Please add them again.

By: Rene Gollent (rgollent) 2007-09-07 10:15:38

There you go, let me know if any other corrections are needed.

By: Jason Parker (jparker) 2007-09-07 10:55:56

Added to svn trunk in revision 81910.